Skip to content

[finding] tenant-audit census applies its engine-door rule to NAMED declarations only, so two real engine writes with inline type-literal receivers are subtracted from the certified population — placing them moves it 225 to 227 and rewrites both artefacts #18944

Description

@os-elon-musk

Filed by the domain:spec execution seat 3 (#18883), session_019srGWGCBBCBHqcDoRZpQRh, from the out_of_scope_findings of the #18548 round (PR #18943). ⛔ Filed bare (no domain:*, no priority:*): 「执行席永不定级或路由裸卡」. ⛔ Not deduped by this seat — dedupe words at the bottom.

⚠️ This one touches a security-relevant count that other cards cite. Grading and routing are triage's, but the number is not cosmetic.

The defect

scripts/tenant-audit-census.mjs applies its own engine-door rule to NAMED declarations only. A write call site whose receiver type is an inline type literal that states a write door is therefore classified kind: 'other', subtracted from the certified population, and — before PR #18943 — printed nothing.

Two such sites are real engine writes and are subtracted on a clean tree today. ⭐ Both verified by this seat on origin/main, ⛔ not taken on the dev's word:

packages/plugins/plugin-auth/src/audience-gate-test-support.ts:72
    engine.insert('sys_invitation', row, { context: { isSystem: true } }),

packages/plugins/plugin-auth/src/sso-client-secret.ts:303
    await e.update(SSO_PROVIDER_OBJECT, patch, { context: { isSystem: true } });

Receiver types, per the reporting dev: { insert: (name: string, …) => … } | null and engine as unknown as { find(object: string, …); update(object: string, …) }. Both write under an elevated context (isSystem: true).

⇒ Class (a), a reproducible defect with two named call sites.

Why it is filed rather than fixed in PR #18943

Placing these two moves the certified population 225 → 227 and rewrites both generated artefacts plus the page's hand-written deviation prose. That is a security-relevant number other cards cite, and it wants its own review rather than riding a diagnostics card. ⇒ the right call, and this seat agrees: a card whose acceptance was 「say what you could not place」 should not also silently re-baseline the population it reports on.

They are no longer invisible. PR #18943 names both on every run and counts them under enforcement, so the silence this card is about is already gone — what remains is the placement decision.

What this seat verified vs relayed

Verified on the tree: both call sites exist as quoted, at the named files and lines, and both are engine writes under an elevated context. The seven-reason closed set is present on PR #18943's head and absent from main. The census's single executable git ls-files enumeration is unchanged by that PR (one execFileSync on both sides; its four new mentions are docblock prose).

Relayed, not re-measured by this seat: the 225 → 227 figure, the receiver-type spellings, and the claim that the page carries hand-written deviation prose that would need rewriting.

查重词

anonymous type literal · receiver door signature · memberIsEngineDoor · tenant-audit population · named declarations only


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions