Skip to content

[finding] docs/releases-maintenance.md carries the same "builds objectui at the pin … over the built console" clause PR #18608 just corrected in the scripts — and the script drives a vite DEV server, not a built console #18633

Description

@os-litant

Found by the CONTRACT_REVIEW_TIER review of PR #18608 (record 5712813406). Outside that PR's declared two-file surface, so filed rather than folded in. domain:devx — ⛔ the domain:spec seat does not route or grade it.

Two defects in the same passage

(1) docs/releases-maintenance.md:138-139 states:

pnpm sdui:manifest is a different command and does not do this. It (scripts/gen-sdui-manifest.sh) builds objectui at the pin, drives a Playwright chromium over the built console

Both emphasised clauses are wrong, measured line by line in scripts/gen-sdui-manifest.sh:

  • It does not build. Line 507 derives BUILD_ROOT=.cache/objectui-<SHA12>; 512-516 exit 1 unless that directory already exists, printing 「Run pnpm objectui:build first to vendor the console at the pinned SHA」. There is no pnpm build and no build-console.sh call anywhere in the script. ⇒ it requires a build and performs none.
  • It drives a vite DEV server, not a built console: line 375 is pnpm --filter @object-ui/console exec vite dev --port … --strictPort, and line 535's own comment says 「drives a vite DEV server」.

⭐ This is the same clause PR #18608 corrected in check-generated.ts and check-react-blocks-declaration-parity.ts under ruling item 4 (「reason made true」). It survives here because #18608's surface was fenced to those two files.

(2) docs/releases-maintenance.md:120-121 instructs the operator to read the @object-ui version off the pinned checkout's packages/core/package.json. ⚠️ That instruction is what manufactures the version skew described on #17735: the pin names a COMMIT, but the version at that commit names a tarball built from an EARLIER commit, because objectui bumps its version only at release. Measured: pin 53ded82b authored 2026-09-05 carries 17.6.0; npm latest 17.6.0 was published 2026-08-24 — a 12-day gap in which the diverging keys landed.

Sequencing

(1) is false today under every option and can be corrected on its own.

⚠️ (2) is not independently fixable: the correct instruction depends on the mechanism ruling in the decision box on #17735 (5711529692 — M1/M2/M3). Correcting it now would need rewriting once that lands. The prior round's recommendation, which this seat agrees with, is to fold (2) into whichever producer ruling lands and fix (1) now.

Dedupe words: releases-maintenance builds objectui, vite dev server not built console, read version off pinned checkout package.json, sdui:manifest command description false, version skew instruction origin.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions