Skip to content

ComponentPropsMap map/gantt/tree rows: two shipped describes are imprecise (lat-lng pair marked required; navigation list omits new_window) plus two records the pin gate will not re-check #18459

Description

@os-warren

Filed bare and ungraded by the domain:spec execution seat, session session_01KB5PFtxuy1x3dcR5gxudx6, 2026-09-16T11:5xZ. domain:*, type and priority are triage's. ⛔ Not claimed, ⛔ not dispatched.

Dedupe keywords: ComponentPropsMap, object-map map describe, locationField optional, NavigationModeSchema new_window, objectui-pin-citations historical spelling.

Why this exists: carried BEFORE its PR was enqueued, so the landing settles nothing it did not

PR #18403 passed at-tier contract review at head c431c22e05 (record 5697057114, VERDICT: PASS). That review named four non-blocking imprecisions and said the seat may fold them into the next round touching those lines. ⭐ Two of them ship into the public reference (content/docs/references/ui/component.mdx), so they are recorded here rather than left in a review comment.

⚠️ The seat notes plainly: the reviewer judged these non-blocking and the seat adopted its verdict verbatim, as the protocol requires. ⛔ This card is not an appeal of that verdict. It is the carrier for what the verdict explicitly left open.

N1 — ships. The object-map map describe overstates what is required

The describe writes { latitudeField, longitudeField, locationField?, … }, marking the lat/lng pair required.

Measured at the objectui pin 53ded82b: ObjectMapConfigSchema declares all eight keys .optional(), and the renderer's flat branch (ObjectMap.tsx:382) accepts locationField alone. The spec's own ListMapConfigSchema describes locationField as the alternative to the pair.

⇒ an author reading the shipped reference is told to supply two keys when one suffices. The error is conservative — they would write more than needed, nothing is refused (the door is z.unknown()) — which is why it is not blocking. It is still a false statement about the accept set, in text that generates public documentation.

Suggested spelling: latitudeField?, longitudeField?, or "either locationField or the latitudeField/longitudeField pair".

N2 — ships. The navigation mode list omits new_window

Three navigation rows list page | drawer | modal | split | popover | none. The spec's NavigationModeSchema declares seven values including new_window, and objectui's useNavigationOverlay.ts switches on it at the pin (:298, 5 hits).

⚠️ Inherited, not introduced: the existing object-grid row lists five of the seven (no popover, no new_window), so this PR's list is closer to complete than the precedent it copied. Fixing it means fixing the family, not just these three rows.

N3 — source only, never generated

component.test.ts carries two comment citations that were not carried when the zod headers were corrected: :3425 reads label (:1849) where the read is :1871; :3521 reads "ObjectGantt.tsx:501 validates" where the safeParse is :500. Same class as the F3 items that round fixed in the schema headers.

N4 — gate coverage, not text truth

The three new schema headers cite the pin in the historical spelling ("measured at the .objectui-sha pin 53ded82b") while the sibling #7751 rows use the asserting spelling (.objectui-sha = 53ded82bf, 7 sites). check:objectui-pin-citations therefore counts these ~45 line anchors among its "36 historical not checked" and will not flag them on the next pin bump. The gate permits the historical form, so nothing is violated — but ~45 anchors that exist to stay re-checkable are, in practice, not being checked.

Provenance

PR #18403 · its at-tier record 5697057114 (items N1-N4) · card #18305.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions