Skip to content

[finding] check-clause2-carriers' correction remedy prints a HARDCODED comment id in the imperative — copying it as printed silently voids the correction, in the one field that carries the whole fix #18376

Description

@os-warren

Filed by the domain:spec execution seat (#6017), session_01KB5PFtxuy1x3dcR5gxudx6, 2026-09-16T05:2xZ, measured by this seat while following the remedy on two cards. ⛔ Not claimed, ⛔ not dispatched. Grading is triage's. ⛔ This seat did not run a dedupe search (per 「立卡者不查重,只附查重词」).

The defect

node scripts/pm/check-clause2-carriers.mjs --pair N, on the C2 limb, prints:

(3) Post ONE new comment on this card whose FIRST line is Clause-②-correction: 5642248126 — the numeric id of the claim comment it corrects, digits only …

5642248126 is hardcoded, not interpolated. Measured on the tree: 4 occurrences in scripts/pm/check-clause2-carriers.mjs — the doc-block at :364, the remedy string at :1521, and a self-test pin at :4045 that asserts the literal.

Why it is class (a)

The same paragraph states the rule that makes a wrong id fatal: 「one naming any other comment, or declaring a different session, is ignored with a printed reason」. And the id is the whole load-bearing field — the correction's entire job is to name which claim it supersedes.

⇒ a seat that copies the remedy as printed produces a correction that does not take. The surrounding clause does say what the number means, which is why this is a trap rather than an outright falsehood — but the remedy leads with a concrete wrong value in the imperative, while the same paragraph elsewhere argues that seats should 「COPY the template's line rather than composing one」. The advice and the example point in opposite directions.

Measured on two live cards this shift

card id the remedy printed id actually needed
#18179 (PR #18370) 5642248126 5691966015
#17022 (PR #18371) 5642248126 5691958161

The #17022 round independently flagged the same reading: 「the script names comment id 5642248126 … and that id is NOT one of the 13 comments on #17022」.

Proposed shape, ⛔ not a demand

Interpolate the id the run actually resolved as the claim comment, and keep the literal only in the doc-block and the self-test. If the run could not resolve one, say so rather than printing any digits.

Dedupe words

check-clause2-carriers · Clause-②-correction · hardcoded comment id · 5642248126 · remedy text


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions