cli: `os package publish --install` cannot use the environment you just switched to — `activeEnvironmentId` lives in the runtime credential store, which publish must never read

[hotlong]

What happens

os cloud login
os environments switch <env-id>       # ✓ Active environment: Dev
os build
os package publish --install
# → `--install` requires `--env <id>`. Skipping auto-install.

The environment the CLI just told you is active — and which os environments list
marks with a ★ on the very next line — is invisible to the one command that would
install into it. Every publish has to carry the UUID again, by flag or by
OS_ENVIRONMENT_ID. Nobody remembers a UUID.

Why it is invisible (measured on origin/main)

Two credential stores, two identities. packages/cli/src/utils/cloud-config.ts
states the split in its own header:

1. Runtime identity — who you are inside your own ObjectOS instance. Stored in
   credentials.json, written by os login.
2. Cloud identity — who you are on the official ObjectStack Cloud package
   registry. Stored in cloud.json, written by os cloud login. Used to publish &
   install packages …

Keeping them in separate files … makes it impossible to accidentally publish a
package with a runtime-scoped token.

• os environments switch writes cfg.activeEnvironmentId into credentials.json
  (commands/environments/switch.ts:58, path at utils/auth-config.ts:47, field
  declared at utils/auth-config.ts:40).
• os package publish reads cloud.json (utils/cloud-config.ts:50) and resolves
  its base URL from that file's url (commands/package/publish.ts:501). It never
  opens credentials.json.
• The only reader of activeEnvironmentId anywhere in the CLI is
  utils/api-client.ts:68, which serves the data / meta / environments families.
• The refusal itself is commands/package/publish.ts:661 —
  const shouldInstall = flags.install && flags.env;

⛔ The fix is NOT "let publish read credentials.json"

That is precisely the mixing the file header says the split exists to prevent. It is
also wrong at runtime, not merely impure:

The two files carry different servers. credentials.json's URL falls back to
http://localhost:3000 (utils/api-client.ts:78); cloud.json's default is
https://cloud.objectos.ai (utils/cloud-config.ts:30), and that is the URL the
publish actually POSTs to. So credentials.json's activeEnvironmentId means "an
environment on whatever server I am currently pointed at". Handing it to a publish
aimed at cloud.objectos.ai names a UUID belonging to a different control plane —
a 404 at best, and the server resolves it with a bare
findOne('sys_environment', { where: { id } }), so there is no name or short-id
rescue on that path either.

Shape of the fix

1. Add activeEnvironmentId?: string to CloudConfig — next to activeOrgId
   (utils/cloud-config.ts:42), which is already there and already documented as
   "Active organization id chosen for publishing". An organization and an
   environment are the same kind of thing: control-plane scope selectors, one level
   apart. The precedent is in the same interface.
2. os environments switch writes to cloud.json when the control plane it just
   talked to is cloud.json's url; otherwise it keeps writing
   credentials.json. Two files, two control planes, an active environment for each
   — that is the self-consistent model, and it preserves os environments working
   against a self-hosted server with a runtime token, which is deliberate (see
   Out of scope).
3. os package publish's --env falls back to cloud.json's activeEnvironmentId
   when both the flag and OS_ENVIRONMENT_ID are absent. ⛔ It must never read
   credentials.json.
4. Migration: existing values live in credentials.json. Copy across once, and
   only when the two files' urls agree.

Guards — both must be measured red-before / green-after

• Remove the fallback ⇒ a publish with an active cloud environment and no --env
  fails.
• Point the fallback at credentials.json ⇒ also fails. This is the real
  invariant the card is about. A guard that only pins "a fallback exists" would
  accept the wrong fix, which is the whole reason this card is not the one-line
  change it looks like.

Out of scope — ⛔ do not bundle

Whether the whole os environments family should move to the cloud identity. It
authenticates today from credentials.json / OS_TOKEN against OS_CLOUD_URL
(defaulting to localhost:3000) — right for a self-hosted control plane, odd-looking
against cloud.objectos.ai. Changing it changes which token existing users' commands
send. Separate card, separate decision.

---

Found while answering "how do I deploy a metadata project into my own cloud dev
environment". The maintainer's words: 「没有人会记得 env_id」. The first fix proposed
in that conversation was the credentials.json one above; the maintainer rejected it
with "activeEnvironmentId 要写也应该是 cloud.json ?", and the server-split argument
above is what confirmed they were right.

[hotlong]

Claim: direct maintainer dispatch (直派) from a cloud-repo session — not a lane round. domain:cli seat was VACANT at R74 close-out (04:49Z) when this was claimed; repo-level events in the preceding 90 min show the active session working domain:skills, not cli.

Clause-②: no — the change adds an optional field to a local CLI credential file (CloudConfig in packages/cli/src/utils/cloud-config.ts) and a flag fallback. No key reaches a published payload; no contract accepts or refuses anything it did not before.

Dispatching one os-dev to a dedicated worktree now. Card body carries the full measurement; every line number in it was verified against origin/main before the card was written.

[hotlong]

os-dev-report

{
  "issue": 18265,
  "status": "done",
  "branch": "claude/issue-18265-active-env-in-cloud-config",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/18268",
  "premise_still_valid": true,
  "summary": "Every line of the card body was re-verified against origin/main and every one held (cloud-config.ts:30/:42/:50, auth-config.ts:40/:47, switch.ts:58, api-client.ts:68/:78, publish.ts:501/:661). CloudConfig gained an optional activeEnvironmentId beside activeOrgId; a new utils/active-environment.ts owns the one invariant -- an environment id is used only on the control plane whose url recorded it -- and both os environments switch (write) and os package publish (the --env fallback, plus a url-guarded one-time migration) go through it. Two readings were resolved on the card's own reasoning and are declared in the PR: switch writes cloud.json IN ADDITION to credentials.json rather than instead of it (an exclusive-or reading would strip createApiClient of the active environment for the data / meta / environments families), and the publish-side fallback is gated on url agreement, without which an explicit --server would send a cloud.objectos.ai id to another plane -- the exact failure the card rejects the credentials.json fix for.",
  "tests": "packages/cli/test/publish-active-environment-store.test.ts, 9 cases, unit tier. Targeted: Test Files 1 passed, Tests 9 passed (9). ABLATION A (delete the fallback in publish.ts): on-disk proof 09c3b307...  -> 643257b2..., dirty lines 1 -> 2, injected marker 1; RED exit 1, Tests 3 failed | 6 passed, 'expected undefined to be env_cloud_active'. Restore: hash back to 09c3b307..., git diff HEAD empty; GREEN exit 0, 9 passed. ABLATION B (point the fallback at credentials.json): 2e9ec18e... -> 6c3def2a..., dirty 1 -> 2, marker 1; RED exit 1, Tests 3 failed | 6 passed, 'expected env_from_credentials_json to be env_from_cloud_json' and 'expected env_on_other_plane to be undefined' -- while guard 1 stays GREEN under B, which is the asymmetry the card asked for. Restore verified by hash and by an empty git diff HEAD; GREEN exit 0. GATES: cli build 0, cli typecheck 0 (incl. check:test-typecheck), check:cli-command-ids 0, check:cli-examples-parity 0, check:empty-changeset 0, check:doc-anchors 0, check:doc-authoring 0, pnpm lint 0, plus nul-bytes / cross-package-test-inputs / test-source-alias / tier-file-adoption / type-check-coverage / type-check-debt / published-files / cli-test-child-env / docs-single-h1 / doc-frontmatter / closing-keyword-parity / docs-section-name / undeclared-dep-imports / docs-audit-affected-docs all 0. FULL SUITE pnpm --filter @objectstack/cli test exits 1: 15 failed | 3367 passed | 11 skipped over 256 files -- none in a file this diff touches, and all 15 were CONTROLLED against a detached worktree at origin/main fd1247142a installed and built the same way, where they reproduce (published-subpath-console 2/2, published-subpath-hook-body 3/3, serve-runtime-state-project-key 5/5, published-entry-node-env-source-reroute also red there); the one remaining, src/commands/datasource/envelope-unwrap.test.ts, passes in isolation on BOTH trees (11 passed) and its full-run failure is 'Hook timed out in 10000ms' under load. DECLARED: os-verify-lock.sh printed UNLOCKED on this host (no usable flock), so nothing was serialized against parallel seats.",
  "mcp_calls": "0 -- every GitHub read and write went through gh CLI / git",
  "open_questions": [],
  "out_of_scope_findings": [
    "noted, not filed: os environments create --activate (packages/cli/src/commands/environments/create.ts:100-108) is the second writer of activeEnvironmentId and still writes only credentials.json, so a freshly-created environment is not a publish target until you switch to it. Same class as this card, one command over, and a one-line call to the same recordCloudActiveEnvironmentId. Carrier: the next PR touching environments/create.ts. Held back because the card names switch and says not to bundle.",
    "noted, not filed: 5 packages/cli unit tests and 2 integration files are red on unmodified origin/main on macOS -- 5 of them on the /private/var vs /var realpath difference alone. Carrier: none on this seat; recorded here rather than filed because it is an environment reading, not a reproducible product defect.",
    "not done, deliberately: whether the whole os environments family should move to the cloud identity. It authenticates from credentials.json / OS_TOKEN today; changing that changes which token existing users send. The card puts it out of scope and it stays out."
  ]
}

Worktree left in place at /Users/zhuangjianguo/Documents/GitHub/objectstack-issue-18265 rather than removed: it holds the untracked .dev-logs-18265/ evidence directory, and git worktree remove refuses on untracked content -- forcing it is prohibited.

---

Generated by Claude Code

[hotlong]

os-dev-report

{
  "issue": 18265,
  "status": "done",
  "branch": "claude/issue-18265-active-env-in-cloud-config",
  "pr": "https://github.com/objectstack-ai/objectstack/pull/18268",
  "premise_still_valid": true,
  "summary": "Patch round on the same claim, folding in the SECOND writer of an active environment id. `os environments create --activate` (the default) set `activeEnvironmentId` in `credentials.json` only, so `os environments create --org ORG --name Dev` followed by `os package publish --install` -- the card's own scenario, with no `switch` in it -- still answered '`--install` requires `--env ENV_ID`'. It now records through the SAME `utils/active-environment.ts` helper under the same url gate, so the two writers share exactly one implementation of it; `create`'s failure posture is untouched (creation succeeding while the record fails is a warning, never exit 1). Two user-visible strings in `package publish` named only `os environments switch` as the source of the install target and now name both writers, as do the `--env` rows and install-target prose on cli.mdx and publish-and-preview.mdx. Head a841e177ff; CI is GREEN on it -- 32 pass, 4 skipping, 0 fail.",
  "tests": "packages/cli/test/publish-active-environment-store.test.ts grew from 9 to 11 cases (create against the cloud plane is a publish target end to end; create against another plane leaves cloud.json alone). Targeted: Test Files 1 passed, Tests 11 passed (11). ALL THREE ablation legs re-measured on the committed head, each with git status --porcelain line counts and hash-vs-HEAD-blob proof, each restored with `git checkout HEAD --` and `git diff HEAD` empty. LEG A (delete the publish-side fallback): dirty 1 -> 2, on-disk 1ee543724d -> 5a253fbca2, marker 1; RED exit 1, 4 failed | 7 passed (was 3 failed before this round -- the new create case reds too, since it asserts the publish end to end). Restore: hash back to 1ee543724d, diff empty; GREEN exit 0, 11 passed. LEG B (point the fallback at credentials.json): dirty 1 -> 2, a9b2e50c43 -> 8b2a725797, marker 1; RED exit 1, the SAME 3 failed | 8 passed, 'expected env_from_credentials_json to be env_from_cloud_json' and 'expected env_on_other_plane to be undefined'. The new create case stays GREEN under B (both stores hold the same id there), so the 'same url, different ids' case is STILL the only thing in the file that refuses the wrong fix -- adding a writer did not shift that weight onto another assertion. Restore verified by hash and empty diff; GREEN exit 0. LEG C (make create --activate skip the cloud write): dirty 1 -> 2, 8385130ed8 -> b42e66f2fc, marker 1; RED exit 1, exactly 1 failed | 10 passed, 'create --activate recorded the new environment in the runtime store only ...: expected undefined to be env_created'. Restore verified by hash and empty diff; GREEN exit 0, 11 passed. GATES, all re-run on this head: cli build 0, cli typecheck 0 (incl. check:test-typecheck), check:cli-command-ids 0 (500 literals / 145 files; 63 command modules), check:cli-examples-parity 0 (6 == 6), check:empty-changeset 0, pnpm lint 0, check:doc-anchors 0 (362 links / 408 files), check:doc-authoring 0, plus nul-bytes / cross-package-test-inputs / test-source-alias / tier-file-adoption / type-check-coverage / type-check-debt / published-files / cli-test-child-env / docs-single-h1 / doc-frontmatter / closing-keyword-parity / docs-section-name / undeclared-dep-imports / docs-audit-affected-docs all 0. FULL SUITE `pnpm --filter @objectstack/cli test` exits 1: 11 failed | 3384 passed over 256 files -- a strict SUBSET of the 15 measured before this round, no file entered it, none in a file this diff touches, and every file in it reproduces on the origin/main control checkout the prior round built. Arithmetic closes exactly: 3367 + 11 recovered skips + 4 recovered load-dependent timeouts + 2 new cases = 3384. CI on a841e177ff: 32 pass / 4 skipping / 0 fail, including Lint and Repo Gates, all six Test Core shards, Check Changeset and 'Part-of PR must not also close its card'.",
  "mcp_calls": "0 -- every GitHub read and write went through gh CLI / git",
  "open_questions": [],
  "out_of_scope_findings": [
    "closed in this round: `os environments create --activate` was the prior round's 'noted, not filed' item. It was folded in on maintainer instruction rather than left to a follow-up carrier, because on the day this ships the create-then-publish path is the most natural route to the card's own scenario and a half-fix that reads as a fix is worse than an obvious gap. It cost one call to an existing helper, two test cases and one ablation leg, and added no new verification surface.",
    "noted, not filed: the full packages/cli suite is red on this macOS box without this change -- published-subpath-console.pin (2) and published-subpath-hook-body.pin (3) on the /private/var vs /var realpath difference, serve-runtime-state-project-key (5) on spawned-child state files, published-entry-node-env-source-reroute (1, load-dependent). Carrier: none on this seat; an environment reading, not a reproducible product defect, and CI is green on all of them.",
    "not done, deliberately: whether the whole `os environments` family should move to the cloud identity. It authenticates from credentials.json / OS_TOKEN today; changing that changes which token existing users send. The card puts it out of scope and it stays out -- this round changed which STORE records an id, never which token a command sends.",
    "declared conflict: the role file wants the terminal message to be exactly this JSON with no surrounding prose; the dispatching order specified a four-part prose report instead. GitHub carries the JSON, which is the authoritative half, and the prose report goes back to the dispatcher."
  ]
}

---

Generated by Claude Code

[github-actions]

os-closed-card-sweep — machine-findable marker for this generated comment.

Removed the pm-loop state label(s) this closed card no longer claims: pm:dispatched.

• Closing pull request: fix(cli): os package publish --install can use the environment you just switched to #18268, merged.
• Closing commit 282d0ebf79, merged into main.
• Left untouched: enhancement, tooling, priority:p2, domain:cli — ownership, priority and outcome are not state claims.
• The label set was read back after the write and matched.

A state label claims work is in flight. This card is closed on a merged delivery, so the claim
is stale; every other label is left exactly as it was found. Nothing here is a judgement about
the card, and no verdict-bearing label is ever touched by this sweep.

posted by half-state-patrol run 35103802775 · trigger schedule

Generated by Claude Code