You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up to #16718, whose PR corrected 57 statements inside the boundary that card measured. This one is the residue outside its regex.
Why a second card rather than a wider first one
#16718's pattern was a proxy, not a census. It is case-sensitive on enterprise and does not see the neighbouring cloud-private / enterprise package spellings. Roughly 60 more statements using that vocabulary live outside it — in packages/spec, packages/types, packages/services/service-cluster, packages/rest, packages/core, and several plugin-dev / plugin-auth test headers.
Folding them into #16718 was declined deliberately: it would have blown past the boundary that card measured and reopened a population sort over packages the dev had not verified sentence by sentence.
⛔ The reason this is not a find-and-replace
Most of these are probably correct.security-enterprise, service-ai-studio and the multi-node gate carrier really are commercial, and prose calling them enterprise is true and must survive. The job is a per-sentence population sort, exactly as #16718 defined it:
Now false — the sentence is about @objectstack/organizations, which ADR-0132 made Apache-2.0 open core. Confirmed instance to start from: packages/plugins/plugin-dev/src/dev-plugin-tenancy-posture.test.ts:23 still calls it "a cloud-private enterprise package".
Still true — the sentence is about a genuinely private package. ⛔ Leave it. Do not "harmonise" the vocabulary.
Because the same name now denotes two packages — the open one and cloud's private subclass — every edit must say which it means. A sentence ambiguous between them is not fixed, it is differently wrong.
Scope
All spellings of the @objectstack/organizations name only. ⛔ Not a general sweep of the words "enterprise" or "cloud-private" across the tree.
Acceptance
population 1 corrected; state how many hits were left alone and why, per package — "I edited fewer files than the count" is otherwise indistinguishable from missing some
⛔ no behaviour change: prose only. If logic needs editing, stop and report
tests that pin wording are updated deliberately with their reason recorded, ⛔ never silently
Follow-up to #16718, whose PR corrected 57 statements inside the boundary that card measured. This one is the residue outside its regex.
Why a second card rather than a wider first one
#16718's pattern was a proxy, not a census. It is case-sensitive on
enterpriseand does not see the neighbouringcloud-private/enterprise packagespellings. Roughly 60 more statements using that vocabulary live outside it — inpackages/spec,packages/types,packages/services/service-cluster,packages/rest,packages/core, and severalplugin-dev/plugin-authtest headers.Folding them into #16718 was declined deliberately: it would have blown past the boundary that card measured and reopened a population sort over packages the dev had not verified sentence by sentence.
⛔ The reason this is not a find-and-replace
Most of these are probably correct.
security-enterprise,service-ai-studioand the multi-node gate carrier really are commercial, and prose calling them enterprise is true and must survive. The job is a per-sentence population sort, exactly as #16718 defined it:@objectstack/organizations, which ADR-0132 made Apache-2.0 open core. Confirmed instance to start from:packages/plugins/plugin-dev/src/dev-plugin-tenancy-posture.test.ts:23still calls it "a cloud-private enterprise package".Because the same name now denotes two packages — the open one and cloud's private subclass — every edit must say which it means. A sentence ambiguous between them is not fixed, it is differently wrong.
Scope
All spellings of the
@objectstack/organizationsname only. ⛔ Not a general sweep of the words "enterprise" or "cloud-private" across the tree.Acceptance