Skip to content

fix: align metadata plugin tests with refactored start() implementation#1164

Merged
hotlong merged 1 commit intomainfrom
copilot/build-test-fix-errors
Apr 16, 2026
Merged

fix: align metadata plugin tests with refactored start() implementation#1164
hotlong merged 1 commit intomainfrom
copilot/build-test-fix-errors

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

MetadataPlugin.start() was refactored to bridge ObjectQL via ctx.getService('objectql') + setDataEngine(), but tests still asserted the old ctx.getServices() + setDatabaseDriver() pattern — causing 2 test failures.

Changes

  • Updated test assertions in packages/metadata/src/metadata.test.ts to verify setDataEngine instead of setDatabaseDriver
  • Updated mock setup — tests now mock ctx.getService('objectql') instead of ctx.getServices() returning a driver.* map entry
  • Added missing methods to NodeMetadataManager mock classsetDataEngine, setRealtimeService
// Before (stale)
ctx.getServices = vi.fn().mockReturnValue(services); // services.set('driver.mock-driver', ...)
expect(manager.setDatabaseDriver).toHaveBeenCalledWith(mockDriver);

// After (matches plugin.ts)
ctx.getService = vi.fn().mockImplementation((name) => name === 'objectql' ? mockObjectQL : null);
expect(manager.setDataEngine).toHaveBeenCalledWith(mockObjectQL);

Full test suite passes: 87/87 tasks, 175/175 metadata tests.

…ntation

Tests now verify setDataEngine (via getService('objectql')) instead of the
removed setDatabaseDriver (via getServices()) pattern. Added setDataEngine
and setRealtimeService to the NodeMetadataManager mock class.

Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/eab49cb9-b023-444c-a757-c12cfac1d136

Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectstack-demo Ready Ready Preview, Comment Apr 16, 2026 5:56am
spec Ready Ready Preview, Comment Apr 16, 2026 5:56am

Request Review

@xuyushun441-sys xuyushun441-sys marked this pull request as ready for review April 16, 2026 05:56
@hotlong hotlong merged commit 98abb94 into main Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants