fix: align metadata plugin tests with refactored start() implementation#1164
Merged
fix: align metadata plugin tests with refactored start() implementation#1164
Conversation
…ntation
Tests now verify setDataEngine (via getService('objectql')) instead of the
removed setDatabaseDriver (via getServices()) pattern. Added setDataEngine
and setRealtimeService to the NodeMetadataManager mock class.
Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/eab49cb9-b023-444c-a757-c12cfac1d136
Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
xuyushun441-sys
April 16, 2026 05:56
View session
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MetadataPlugin.start()was refactored to bridge ObjectQL viactx.getService('objectql')+setDataEngine(), but tests still asserted the oldctx.getServices()+setDatabaseDriver()pattern — causing 2 test failures.Changes
packages/metadata/src/metadata.test.tsto verifysetDataEngineinstead ofsetDatabaseDriverctx.getService('objectql')instead ofctx.getServices()returning adriver.*map entryNodeMetadataManagermock class —setDataEngine,setRealtimeServiceFull test suite passes: 87/87 tasks, 175/175 metadata tests.