Skip to content

Evaluating remote package installation strategies#1163

Merged
xuyushun441-sys merged 2 commits intomainfrom
claude/evaluate-dynamic-package-installation
Apr 16, 2026
Merged

Evaluating remote package installation strategies#1163
xuyushun441-sys merged 2 commits intomainfrom
claude/evaluate-dynamic-package-installation

Conversation

@Claude
Copy link
Copy Markdown
Contributor

@Claude Claude AI commented Apr 16, 2026

Pull request created by AI Agent

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
objectstack-demo Ready Ready Preview, Comment Apr 16, 2026 5:26am
spec Ready Ready Preview, Comment Apr 16, 2026 5:26am

Request Review

@github-actions github-actions bot added dependencies Pull requests that update a dependency file tooling size/m labels Apr 16, 2026
Comment thread packages/cli/src/commands/publish.ts Outdated
// Copyright (c) 2025 ObjectStack. Licensed under the Apache-2.0 license.

import { Args, Command, Flags } from '@oclif/core';
import chalk from 'chalk';
Comment thread packages/cli/src/commands/publish.ts Outdated
import chalk from 'chalk';
import { loadConfig } from '../utils/config.js';
import { printHeader, printKV, printSuccess, printError, printStep } from '../utils/format.js';
import { existsSync } from 'node:fs';
@xuyushun441-sys
Copy link
Copy Markdown
Contributor

@copilot fix ci build and test errors

- Add @objectstack/service-package as dependency in packages/rest/package.json
  (fixes TS2307: Cannot find module '@objectstack/service-package')
- Add @objectstack/service-package as dependency in apps/server/package.json
  (fixes runtime import resolution for objectstack.config.ts)
- Remove unused imports (chalk, existsSync) in packages/cli/src/commands/publish.ts
  (fixes CodeQL warnings)
- Add --passWithNoTests flag to service-package test script
  (fixes vitest exit code 1 when no test files exist)
- Update pnpm-lock.yaml

Agent-Logs-Url: https://github.com/objectstack-ai/framework/sessions/48f26ce0-a828-4ddf-8168-3ba164c66cf9

Co-authored-by: xuyushun441-sys <255036401+xuyushun441-sys@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 16, 2026

@copilot fix ci build and test errors

Fixed in cd3838c. The CI failures had 4 root causes:

  1. Build errorpackages/rest and apps/server imported @objectstack/service-package but didn't declare it as a dependency → added workspace:* dependency to both package.json files
  2. CodeQL warnings — unused chalk and existsSync imports in packages/cli/src/commands/publish.ts → removed
  3. Test failureservice-package had no test files, causing vitest run to exit with code 1 → added --passWithNoTests flag
  4. Lockfile — updated pnpm-lock.yaml for the new dependency entries

Verified locally: build 45/45 tasks pass, tests 87/87 tasks pass.

Copilot AI requested a review from xuyushun441-sys April 16, 2026 05:27
@xuyushun441-sys xuyushun441-sys marked this pull request as ready for review April 16, 2026 05:27
@xuyushun441-sys xuyushun441-sys merged commit 1f54410 into main Apr 16, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file size/m tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants