Updated Android releases.yml for keystore and google-services secrets - #538
Open
hardikgarg02 wants to merge 7 commits into
Open
Updated Android releases.yml for keystore and google-services secrets#538hardikgarg02 wants to merge 7 commits into
hardikgarg02 wants to merge 7 commits into
Conversation
Collaborator
|
Two gaps before this works: neither robot/build.gradle nor controller/build.gradle has a signingConfigs block wired to these injected properties, so assembleRelease would still produce an unsigned APK (likely named robot-release-unsigned.apk, not robot-release.apk as the asset-path step expects). Also, none of the 5 secrets this references (GOOGLE_SERVICES_JSON_BASE64, KEYSTORE_BASE64, KEYSTORE_PASSWORD, KEY_ALIAS, KEY_PASSWORD) exist in the repo yet. Can you add the signingConfigs block and confirm the secrets are ready before this merges? |
…android-release-secrets
…android-release-secrets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.