feat!: separate image.repository into (image.registry / image.repository) and support .global.imageRegistry #367
+111
−100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FieteO
force-pushed
the
global-imageregistry
branch
from
ca2ec4d to
b70c902
Compare
tuunit
reviewed
Nov 12, 2025
FieteO
force-pushed
the
global-imageregistry
branch
from
6dbcbad to
4614108
Compare
tuunit
changed the title
tuunit
changed the title
tuunit
reviewed
Nov 16, 2025
tuunit
changed the title
tuunit
changed the title
tuunit
force-pushed
the
global-imageregistry
branch
from
4614108 to
df90846
Compare
- introduce `.global.imageRegistry` value to allow global configuration of the image registry - split up `image.repository` into `image.registry` and `image.repository` to allow separate configuration - use `image.registry` if `.global.imageRegistry` is not set Signed-off-by: Fiete Ostkamp <F.Ostkamp@web.de> Signed-off-by: Jan Larwig <jan@larwig.com>
Co-authored-by: Pierluigi Lenoci <pierluigi.lenoci@sap.com> Signed-off-by: Fiete Ostkamp <F.Ostkamp@web.de> Signed-off-by: Jan Larwig <jan@larwig.com>
Signed-off-by: Fiete Ostkamp <F.Ostkamp@web.de> Signed-off-by: Jan Larwig <jan@larwig.com>
tuunit
force-pushed
the
global-imageregistry
branch
from
c20c07b to
fc5af29
Compare
Signed-off-by: Jan Larwig <jan@larwig.com>
tuunit
force-pushed
the
global-imageregistry
branch
from
912a6c4 to
916a59b
Compare
tuunit
approved these changes
Nov 20, 2025
Member
|
@pierluigilenoci I reworded the breaking change notice in the README and Chart.yaml and the large changes in the README are due to the fact that the markdown table was unformatted and the global.imagePullSecret and global.imageRegistry was missing. LGTM now |
pierluigilenoci
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
.global.imageRegistryvalue to allow global configuration of the image registryimage.repositoryintoimage.registryandimage.repositoryto allow separate configurationimage.registryif.global.imageRegistryis not setChecklist: