Repository navigation
bump: oasdiff v1.34.1 - #209
Merged
Merged
Conversation
v1.34.1 applies the external-refs policy in the reader that --open installs, which every action that uploads a review uses. Without it allow-external-refs: false had no effect on that path, so a spec in a pull request could read a file from the runner or reach a URL, and the content went into the uploaded review. Reported-by: Zachariah Mithani (AploSec) Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017e285CvofYf6joqC98gTXz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
oasdiff v1.34.1 enforces
--allow-external-refs=falsein the reader that--openinstalls. Every action that uploads a review uses that path, so without the fix theallow-external-refsinput had no effect there: a spec in a pull request could read a file from the runner or reach a URL, and the content went into the uploaded review.The input itself was already correct, and defaults to
false. Only the enforcement was missing, one layer down.Bumps the base image on all six actions.
Reported by Zachariah Mithani (AploSec). See GHSA-6h8r-wgc5-q3xv.
🤖 Generated with Claude Code
https://claude.ai/code/session_017e285CvofYf6joqC98gTXz