Conversation
AaronDDM
requested review from
benjaminwhtan,
googsvg,
pengfeiye and
radenkovic
- Default POST, PUT, PATCH, DELETE payload to {} when request_body is nil
to ensure Content-Type: application/json is sent
- Add request_body support to DELETE (e.g. cancellation_reason for bookings)
- Updated comments for POST, PUT, PATCH, and DELETE methods to improve readability and maintain consistency in parameter descriptions. - Ensured that the documentation accurately reflects the behavior of each method, including default values for request bodies and additional headers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes HTTParty content type issue when request body is nil.
Changes
{}whenrequest_bodyis nil to ensureContent-Type: application/jsonis sent (HTTParty omits the header when payload is nil)request_bodyparameter support (e.g.cancellation_reasonfor bookings)destroynow accepts optionalrequest_bodyfor cancellation reasons