Code editor: in-editor find / replace bar - #296
Open
enriquevelmai wants to merge 1 commit into
Open
enriquevelmai wants to merge 1 commit into
enriquevelmai wants to merge 1 commit into
Conversation
A small bar floats over the code editor when it has focus: live search with all matches highlighted, position/total counter, case and whole word toggles, Enter / Shift+Enter to step, Esc to close. Ctrl+R shows the replace row (Replace / Replace All), only enabled while editing. Match highlights live alongside the current line highlight so the two do not clobber each other, and are re-evaluated when the shown node changes.
Contributor
|
@enriquevelmai we haven't released the version that has a lot of this functionality already included in it. We will take a look at the PR against our latest and make sure we're on the same page. We should get back to you soon. Thanks for the PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a find / replace bar that floats over the code editor:
Ctrl+Fopens it (prefilled with the current single-line selection). Live search, all matches highlighted, active match selected,n/totalcounter.Aa/Wtoggles for case sensitive and whole word.Enter/Shift+Enter(or Next / Prev) step through with wrap around.Esccloses.Ctrl+Ralso shows the replace row (Replace / Replace All), enabled only while the code is editable.The current line highlight and the match highlights are both extra selections, so they are now applied together (
apply_extra_selections) instead of overwriting each other.Note: the window level Find and Replace action also uses
Ctrl+F. The editor only claims the shortcut while it has keyboard focus, so the graph-wide finder keeps working everywhere else.