Syntax highlighter: format every match on a line - #294
Open
enriquevelmai wants to merge 1 commit into
Open
enriquevelmai wants to merge 1 commit into
enriquevelmai wants to merge 1 commit into
Conversation
Iterate matches with QRegularExpression.globalMatch instead of re-running
match() from the start of the line, which stopped after the first hit.
The nested ${} extra-char logic is computed once per block.
Contributor
|
@enriquevelmai thank you for the PR. You're a busy person. We really appreciate it. We will take a look against our latest updates and respond here and let you know about the updates asap. Thanks for your patience. |
wyoder
self-requested a review
September 24, 2026 15:00
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The highlighter loop only formatted the first match of each rule per line (
capturedStart(text)returned -1 after the first hit). This iterates matches withglobalMatchso all keywords, operators, strings and ${} tokens on a line get highlighted. Nested-token handling is unchanged, just computed once per block.