fix(files): properly normalize root directory on Windows#2277
Closed
TheLeoP wants to merge 1 commit intonvim-mini:mainfrom
Closed
fix(files): properly normalize root directory on Windows#2277TheLeoP wants to merge 1 commit intonvim-mini:mainfrom
TheLeoP wants to merge 1 commit intonvim-mini:mainfrom
Conversation
Member
Author
|
Actually, after this PR, simply hovering one of require("mini.files").setup {
windows = {
preview = true,
},
}
vim.api.nvim_create_autocmd("User", {
pattern = "MiniFilesWindowUpdate",
callback = function()
local s = MiniFiles.get_explorer_state()
end,
}) |
Member
Author
|
This PR already handles the most common case of root directory normalization in Windows, but after a few iterations I ended up with if H.is_windows then
H.fs_normalize_path = function(path)
path = path:gsub('\\', '/')
local head, tail = path:match('^(%w:/+)(.*)$')
-- preserve number of slashes if 1 or 2, normalize more than 2 slashes to 1
if #head > 4 then head = head:gsub('/+', '/') end
tail = tail:gsub('(.)/$', '%1')
return head .. tail
end
endinstead that also handles the aforementioned special paths that require specifically |
Contributor
|
This fix results in an error for me when using MiniFiles.reveal_cwd(). Please see the fix in my PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in #2272 based on the findings of #2272 (comment)