Skip to content

Comments

fix(sessions): re-detect sessions in read after session is sourced#2267

Merged
echasnovski merged 2 commits intonvim-mini:mainfrom
abeldekat:sessions_update_detected
Feb 14, 2026
Merged

fix(sessions): re-detect sessions in read after session is sourced#2267
echasnovski merged 2 commits intonvim-mini:mainfrom
abeldekat:sessions_update_detected

Conversation

@abeldekat
Copy link
Member

@abeldekat abeldekat commented Feb 13, 2026

After reading a session, the local session stored in MiniSessions.detected can be stale.

Resolve #2260

@abeldekat
Copy link
Member Author

While reading source and test code, I found some spelling errors where "is" should be changed in "are":

line 137
--- beforehand for unsaved listed buffers and stops if there is any.
line 158
return H.message('There is no detected sessions. Change configuration and rerun MiniSessions.setup().')
line 291
H.error('There is no detected sessions. Change configuration and rerun MiniSessions.setup().')

Spelling test:
line 333:
expect.match(get_latest_message(), '%(mini%.sessions%) There is no detected sessions')
line 761:
'%(mini%.sessions%) There is no detected sessions'
line 1005:
T['get_latest()']['works if there is no detected sessions'] = function()

Copy link
Member

@echasnovski echasnovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I didn't think about that, but It indeed makes sense to test different kind of interactions between what was before and what is after read regarding local session. Does the suggestion test sound reasonable?

@echasnovski
Copy link
Member

While reading source and test code, I found some spelling errors where "is" should be changed in "are":

Could you please add another docs(sessions): fix "is/are" typos commit here that addresses all found problems (including tests)? Don't forget to regenerate help files.

@echasnovski echasnovski changed the title feat(sessions): re-detect sessions in read after session is sourced fix(sessions): re-detect sessions in read after session is sourced Feb 14, 2026
@echasnovski
Copy link
Member

echasnovski commented Feb 14, 2026

Also, please adjust the commit message to be fix(sessions) and have Resolve #2260 as part of the message.

@abeldekat abeldekat force-pushed the sessions_update_detected branch from 5ad901c to 7c98b04 Compare February 14, 2026 15:49
@abeldekat abeldekat force-pushed the sessions_update_detected branch from 7c98b04 to 56c8a4a Compare February 14, 2026 15:52
@echasnovski echasnovski merged commit 4ca9885 into nvim-mini:main Feb 14, 2026
12 checks passed
@echasnovski
Copy link
Member

Thanks again for the PR! Everything looks good now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[mini.sessions] List of detected sessions should be updated after loading a new session

2 participants