chore(deps-dev): update trl requirement from >=0.8 to >=1.0.0#29
chore(deps-dev): update trl requirement from >=0.8 to >=1.0.0#29dependabot[bot] wants to merge 1 commit intomainfrom
Conversation
Updates the requirements on [trl](https://github.com/huggingface/trl) to permit the latest version. - [Release notes](https://github.com/huggingface/trl/releases) - [Changelog](https://github.com/huggingface/trl/blob/main/RELEASE.md) - [Commits](huggingface/trl@v0.8.0...v1.0.0) --- updated-dependencies: - dependency-name: trl dependency-version: 1.0.0 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
Greptile SummaryThis PR bumps the Confidence Score: 4/5Not safe to merge without fixing the removed SFTTrainer argument in trainer.py, which breaks all training runs under the new TRL version. One P1 defect: the dependency bump removes an API the codebase actively uses, causing an immediate runtime error on every training invocation. The fix is a one-word rename and carries low overall risk once addressed. src/hippofloop/training/trainer.py — the SFTTrainer call uses a removed argument name that must be updated.
|
| Filename | Overview |
|---|---|
| pyproject.toml | Bumps trl lower bound from >=0.8 to >=1.0.0; the new minimum version removes the deprecated tokenizer argument from SFTTrainer, which the codebase still uses. |
| src/hippofloop/training/trainer.py | Passes old tokenizer keyword to SFTTrainer, which was removed in TRL v1.0.0 (now processing_class); breaks training at runtime under the new dependency constraint. |
Sequence Diagram
sequenceDiagram
participant User
participant UnslothTrainer
participant TRL as SFTTrainer (trl v1.0.0)
User->>UnslothTrainer: train(train_data, val_data)
UnslothTrainer->>TRL: SFTTrainer(model, old_kwarg, ...)
TRL-->>UnslothTrainer: TypeError: unexpected keyword argument
Note over TRL: Removed in v1.0.0 — use processing_class param
Comments Outside Diff (1)
-
src/hippofloop/training/trainer.py, line 99 (link)Removed argument: use
processing_classinsteadThe
tokenizerparameter was deprecated in TRL v0.12.0 and removed in v1.0.0. Under the newtrl>=1.0.0constraint, this line raisesTypeError: __init__() got an unexpected keyword argument 'tokenizer'at runtime, breaking every training run. Rename the keyword toprocessing_class.
Reviews (1): Last reviewed commit: "chore(deps-dev): update trl requirement ..." | Re-trigger Greptile
Updates the requirements on trl to permit the latest version.
Release notes
Sourced from trl's releases.
... (truncated)
Commits
f3e9ac1Release: v1.0 (#5409)e8d5dfcAdd second version of Qwen 3.5 chat template to chat_template_utils (#5405)71ff6a2Add HF_TOKEN environment variable to workflow files (#5397)1ee3975Add vLLM inference to the Base Self-Distillation Trainer (#5388)79e6e79Movedisable_config=TruefromgeneratetoGenerationConfig(#5384)83d68ddchore: updatepr_template_check.yml(#5393)4cb7ab1Enhance PR template check to exclude reopened PRs from first-time contributor...32a40bfEnforce PR template for first-time contributors and document AI usage policy ...8e69b68Mark test_rloo[fsdp2] as xfail for transformers 5.4.0 (#5387)c264266Remove deprecatedTRACKIO_SPACE_IDenv var from all scripts (#5365)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)