Skip to content

docs: remove unsupported cjs polyfills - #3834

Open
danielroe wants to merge 2 commits into
mainfrom
fix/dirname
Open

docs: remove unsupported cjs polyfills#3834
danielroe wants to merge 2 commits into
mainfrom
fix/dirname

Conversation

@danielroe

@danielroe danielroe commented Aug 14, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

spotted this remnant of cjs utils (which aren't present in esm) still here - only working because we load nuxt config files with jiti, but this isn't guaranteed in future.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested a review from farnabaz August 14, 2026 20:06
@vercel

vercel Bot commented Aug 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
content Ready Ready Preview Aug 14, 2026 8:10pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c4d9bdcf-57be-41ce-91ce-62c066083e64

📥 Commits

Reviewing files that changed from the base of the PR and between dc90e96 and 21cfb5f.

📒 Files selected for processing (2)
  • docs/nuxt.config.ts
  • docs/package.json

📝 Walkthrough

Walkthrough

The documentation package is configured as an ES module. The Nuxt configuration now resolves the _redirects file relative to import.meta.dirname instead of __dirname.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 21cfb

This is a localized configuration cleanup with no actionable merge-blocking risk remaining after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the removal of unsupported CommonJS polyfill usage implemented by the changes.
Description check ✅ Passed The description directly explains the CommonJS compatibility issue and the ESM-related fix in the changeset.
✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch fix/dirname
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dirname

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danielroe danielroe changed the title fix: remove unsupported cjs polyfills docs: remove unsupported cjs polyfills Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant