incomplete key sequences should be completed first#693
Open
crides wants to merge 1 commit intonushell:mainfrom
Open
incomplete key sequences should be completed first#693crides wants to merge 1 commit intonushell:mainfrom
crides wants to merge 1 commit intonushell:mainfrom
Conversation
crides
force-pushed
the
incomplete-key-seq
branch
2 times, most recently
from
7673d86 to
b44c463
Compare
Contributor
|
Hey @crides, Will you be continuing to work on this PR or are you out of time/decided it's not useful? |
Contributor
Author
|
From local testing I think it's done |
Contributor
|
the ci doesn't agree with you. 😆 |
Contributor
Author
|
Huh, a bunch of things I didn't touch. I can fix later today |
crides
force-pushed
the
incomplete-key-seq
branch
2 times, most recently
from
f6ff6a8 to
edc57d3
Compare
crides
force-pushed
the
incomplete-key-seq
branch
from
edc57d3 to
6b4126e
Compare
Contributor
Author
|
aight there we go |
Contributor
Author
|
hmm this is not actually general enough (not accounting for insert mode bindings) but I don't think such a case can exist in insert mode right now (not even for custom bindings)? Examples in normal vim/zsh vi mode will be |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue like #473 and #449, but for custom keybindings. Fixed by checking if the current key sequence is complete, and if not, complete it before checking for keybindings.
Added a test for this scenario