Gemini code assist attempt to get everything green#1216
Gemini code assist attempt to get everything green#1216kevmoo wants to merge 1 commit intonushell:mainfrom
Conversation
|
conflicts need to be resolved first. |
Many of these seem great, but I thought I'd include the lot to let you pick through
|
done |
| --before (-b): duration | ||
| --dir (-d) | ||
| --path(-p): list<string@"nu-complete history dir"> | ||
| --path(-p): list<string> |
There was a problem hiding this comment.
Is there not a a nu-complete history dir command to complete this with?
| @@ -1 +0,0 @@ | |||
| source language/playground/lib.nu No newline at end of file | |||
There was a problem hiding this comment.
does removing this break the functionality?
| @@ -1 +0,0 @@ | |||
| source language/std/date.nu | |||
There was a problem hiding this comment.
samme question? does it not exist or what?
| #!/usr/bin/env nu | ||
| use .../stdlib-candidate/std-rfc str | ||
|
|
||
| def dedent []: string -> string { |
There was a problem hiding this comment.
dedent exists in the std-lib or std-rfc. not sure why we need to repeat it here
| def save_screenshot [ method, theme_name ] { | ||
| use .../stdlib-candidate/std-rfc/str | ||
|
|
||
| def dedent []: string -> string { |
There was a problem hiding this comment.
same here, why don't we just use the stdlib where it already exists?
| let ps_script = $" | ||
| use .. * | ||
| source ($name) | ||
| source ../nu-themes/($theme_name).nu |
There was a problem hiding this comment.
i think this depends on where you run it from. might be better to do a const p = path self at the top of the file to figure where we're at first.
fdncred
left a comment
fdncred
left a comment
There was a problem hiding this comment.
Generally ok changes. Just a few comments. I wrote a lot of this slop. LOL. Happy to se it cleaned up. Thanks.
|
For all of these, my code assistant did the hacking. I just told it to try to get analysis green. I 100% try to avoid creating AI slop. In this case I was hoping a few of there were useful. I'm going to close out the PR, but I'll leave the branch if you want to try to cherry-pick any of the one-off things that look reasonable |
2 participants
Many of these seem great, but I thought I'd include the lot to let you pick through