Merged
Conversation
ysthakur
reviewed
Jan 17, 2026
ysthakur
reviewed
Jan 17, 2026
4fd63fe to
f77c53f
Compare
ysthakur
reviewed
Jan 17, 2026
ysthakur
reviewed
Jan 17, 2026
f77c53f to
c982c9a
Compare
ysthakur
approved these changes
Jan 17, 2026
Member
ysthakur
left a comment
There was a problem hiding this comment.
Thanks for the quick changes! Not too familiar with the new parser but this looks simple enough. Let's go for it
Contributor
|
About these, I was thinking we could first implement general-purpose flag parsing logic for custom commands and then reuse that for --env and --wrapped. But this is fine for now. One more thing to keep in mind when adding fields to the AstNode enums is to keep track of the enum size. If one enum variant grows too large, we could optimize it, e.g., by using a separate storage for it with a new Id type, like BlockId or PipelineId. This is just an optimization, not necessary to do now. |
Contributor
Author
|
Sure! I can try to do it next. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I plan to add parser keywords as AstNode variants. I'm not sure if it's a right direction, so here is a small pr about def parsing, it adds
env: boolandwrapped: boolas part of a def ast node.Then these information can be used after parsing.