Remove 278-line dead ScreenshotService and fix fragile FormData Content-Type handling#76
Draft
Remove 278-line dead ScreenshotService and fix fragile FormData Content-Type handling#76
Conversation
…dling Agent-Logs-Url: https://github.com/numbersprotocol/proofsnap-extension/sessions/0e79c934-b3d3-4be8-bb64-45525cb76732 Co-authored-by: numbers-official <181934381+numbers-official@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove dead ScreenshotService and fix Content-Type header handling
Remove 278-line dead ScreenshotService and fix fragile FormData Content-Type handling
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScreenshotServicewas never imported anywhere — screenshot capture lives in the service worker and watermarking inoffscreen.ts.buildAuthHeadersalways injectedContent-Type: application/json, relying on a post-hocdeleteinrequest()to fix it up for FormData uploads — a silent breakage waiting to happen on any pipeline refactor.Changes
src/services/ScreenshotService.ts— 278 lines of dead code, recoverable from git history if ever needed.ApiClient.buildAuthHeaders— accepts a newoptions?: { skipContentType?: boolean }parameter; skips settingContent-Typewhen the caller opts out rather than setting-then-deleting.ApiClient.requestWithAuth— passesskipContentType: trueautomatically whenconfig.body instanceof FormData, making FormData upload behaviour explicit at the call site.README.md— removed staleScreenshotService.tsentry from the key files list.