fix: prevent server-controlled alert injection and username path traversal in popup#74
Draft
fix: prevent server-controlled alert injection and username path traversal in popup#74
Conversation
- Replace raw response.error in alert() calls with safe generic messages to prevent MITM/compromised server social engineering attacks - Validate username against ^[a-zA-Z0-9_.-]+$ and use encodeURIComponent() in openDashboard() to prevent path traversal via unsanitized username Agent-Logs-Url: https://github.com/numbersprotocol/proofsnap-extension/sessions/e6d515c8-e9ff-433f-8fed-166b3d09d87f Co-authored-by: numbers-official <181934381+numbers-official@users.noreply.github.com>
Agent-Logs-Url: https://github.com/numbersprotocol/proofsnap-extension/sessions/e6d515c8-e9ff-433f-8fed-166b3d09d87f Co-authored-by: numbers-official <181934381+numbers-official@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix server error message injection via alert and username sanitization
fix: prevent server-controlled alert injection and username path traversal in popup
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two high-severity findings where server-controlled data was used in the UI without sanitization: raw API error strings rendered via
alert()(social engineering vector) and an unvalidatedusernameinterpolated directly into achrome.tabs.createURL (path traversal risk).Changes
handleCapture,handleUpload): Replaceresponse.errorconcatenation inalert()with static generic messages. Server error is still logged to the console for debugging.openDashboard): Validateusernameagainst^[a-zA-Z0-9_.-]+$before navigation; encode withencodeURIComponent(). Invalid usernames are blocked with aconsole.warn.