Repository navigation
Pass the job's read-only token to the AOT smoke step - #50
Merged
Merged
Conversation
The release run's osx-arm64 smoke failed with 'API rate limit exceeded for 13.105.49.252': hosted runners share IPs, so the 60 anonymous requests an hour can run out mid-run. In CI the smoke step now gets GITHUB_TOKEN (contents: read, masked in logs) and passes it as --token; locally it still runs anonymously. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Make.Fs quotes each interpolated hole as one argument, so ' --token <t>' became part of the --version value. The commands are now argument lists, and --token sits in the command text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the 0.11.6 release run, whose osx-arm64 smoke test failed with
API rate limit exceeded for 13.105.49.252. Hosted runners share IPs, so the 60 anonymous requests an hour ran out mid-run.What
In CI the
smokeaotstep now receives the job'sGITHUB_TOKEN(contents: read, masked in logs). The build script passes it to the three smoke commands as--tokenwhen it is set. Locally the step still runs anonymously.Verify
./build.sh smokeaot -slocally, without a token: passes (find-previous, current-version, generate).curb check: clean.The 0.11.6 tag keeps the old step, so this ships as the next patch release.
🤖 Generated with Claude Code