fix(integration): handle percent_encoded host in extractLocalPort#70
Open
YeonV wants to merge 1 commit into
Open
fix(integration): handle percent_encoded host in extractLocalPort#70YeonV wants to merge 1 commit into
YeonV wants to merge 1 commit into
Conversation
Zig 0.16's std.Uri.parse always stores host as .percent_encoded, never .raw. The .raw branch in extractLocalPort was therefore dead code, causing linked_tracker and linked_boilers to always appear empty even when correctly configured with local URLs. Fix: match both .raw and .percent_encoded in the switch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
extractLocalPortinsrc/core/integration.zigonly matches.rawin its host switch:However, Zig 0.16's
std.Uri.parsealways stores the host component as.percent_encoded, never.raw— as confirmed by Zig's own stdlib tests:This means the
.rawbranch is dead code for any parsed URI. As a result,linked_trackerandlinked_boilersare alwaysnull/empty regardless of the configured URLs, even whenhttp://127.0.0.1:7700is correctly set.Fix
Match both variants in the switch:
Impact
Without this fix, the NullBoiler integration page always shows "NullTickets Link: not found" and the NullTickets page always shows "Linked nullboilers: not found", even when the integration is correctly wired and functionally working.