Skip to content

Conversation

@gminn
Copy link
Contributor

@gminn gminn commented Dec 9, 2025

In #23956, rename of CONFIG_MEMFAULT_DEVICE_INFO_BUILTIN to
CONFIG_MEMFAULT_NCS_DEVICE_INFO_BUILTIN was missed. The migration guide already has this change, so this commit just aligns the code with the migration guide.

Copilot AI review requested due to automatic review settings December 9, 2025 13:55
@gminn gminn requested review from a team as code owners December 9, 2025 13:55
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 9, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a missed symbol rename by updating CONFIG_MEMFAULT_DEVICE_INFO_BUILTIN to CONFIG_MEMFAULT_NCS_DEVICE_INFO_BUILTIN to align with the migration guide from PR #23956.

  • Renamed Kconfig option and all its references
  • Updated preprocessor directives in C code
  • Updated comments to reflect the new symbol name

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
modules/memfault-firmware-sdk/Kconfig Renamed config option, updated default value, and updated conditional and comment references
modules/memfault-firmware-sdk/memfault_integration.c Updated preprocessor directives and comments to use the renamed symbol

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 9, 2025

CI Information

To view the history of this post, click the 'edited' button above
Build number: 2

Inputs:

Sources:

sdk-nrf: PR head: 09cea2155fbeeea7a43862090bfe473795dbabe9

more details

sdk-nrf:

PR head: 09cea2155fbeeea7a43862090bfe473795dbabe9
merge base: 2f82966a9b8c51b3e961c0b647c1e939323f2136
target head (main): 2f82966a9b8c51b3e961c0b647c1e939323f2136
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
modules
│  ├── memfault-firmware-sdk
│  │  ├── Kconfig
│  │  │ memfault_integration.c

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests
Disabled integration tests
    • test-fw-nrfconnect-nrf_lrcs_mosh
    • test-fw-nrfconnect-nrf_lrcs_positioning
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread-main
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@jtguggedal jtguggedal added this to the 3.2.1 milestone Dec 9, 2025
Copy link
Contributor

@jtguggedal jtguggedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I added a milestone and label to get this into the 3.2.1 release

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

You can find the documentation preview for this PR here.

@jtguggedal jtguggedal added the bugfix Fixes a known bug label Dec 9, 2025
@gminn
Copy link
Contributor Author

gminn commented Dec 10, 2025

Noting that because this is now slated for 3.2.1, we'll want to wait to merge until we have confirmation of the docs getting updated in #25910. If that happens, I'll add an entry to the v3.2.1 release notes in the PR with this symbol name change

In nrfconnect#23956,
rename of CONFIG_MEMFAULT_DEVICE_INFO_BUILTIN to
CONFIG_MEMFAULT_NCS_DEVICE_INFO_BUILTIN was missed. The migration guide
already has this change, so this commit just aligns the code with
the migration guide.

Signed-off-by: Gillian Minnehan <gillian.minnehan@nordicsemi.no>
@gminn gminn force-pushed the gminn/fix-memfault-device-info-symbol-rename branch from 8ddbded to 09cea21 Compare December 11, 2025 19:22
@gminn
Copy link
Contributor Author

gminn commented Dec 11, 2025

Noting that because this is now slated for 3.2.1, we'll want to wait to merge until we have confirmation of the docs getting updated in #25910. If that happens, I'll add an entry to the v3.2.1 release notes in the PR with this symbol name change

This entry was gracious updated here to the latest release changelog so we are all set to merge this. Thank you @divipillai and @FrancescoSer !

@gminn
Copy link
Contributor Author

gminn commented Dec 12, 2025

3.2.1 window closed, shooting for 3.2.2 now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport v3.2-branch bugfix Fixes a known bug changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants