-
Notifications
You must be signed in to change notification settings - Fork 1.4k
memfault: fix symbol rename for device info #26168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
memfault: fix symbol rename for device info #26168
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a missed symbol rename by updating CONFIG_MEMFAULT_DEVICE_INFO_BUILTIN to CONFIG_MEMFAULT_NCS_DEVICE_INFO_BUILTIN to align with the migration guide from PR #23956.
- Renamed Kconfig option and all its references
- Updated preprocessor directives in C code
- Updated comments to reflect the new symbol name
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| modules/memfault-firmware-sdk/Kconfig | Renamed config option, updated default value, and updated conditional and comment references |
| modules/memfault-firmware-sdk/memfault_integration.c | Updated preprocessor directives and comments to use the renamed symbol |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 09cea2155fbeeea7a43862090bfe473795dbabe9 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
jtguggedal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added a milestone and label to get this into the 3.2.1 release
|
You can find the documentation preview for this PR here. |
|
Noting that because this is now slated for 3.2.1, we'll want to wait to merge until we have confirmation of the docs getting updated in #25910. If that happens, I'll add an entry to the v3.2.1 release notes in the PR with this symbol name change |
In nrfconnect#23956, rename of CONFIG_MEMFAULT_DEVICE_INFO_BUILTIN to CONFIG_MEMFAULT_NCS_DEVICE_INFO_BUILTIN was missed. The migration guide already has this change, so this commit just aligns the code with the migration guide. Signed-off-by: Gillian Minnehan <gillian.minnehan@nordicsemi.no>
8ddbded to
09cea21
Compare
This entry was gracious updated here to the latest release changelog so we are all set to merge this. Thank you @divipillai and @FrancescoSer ! |
|
3.2.1 window closed, shooting for 3.2.2 now |
In #23956, rename of CONFIG_MEMFAULT_DEVICE_INFO_BUILTIN to
CONFIG_MEMFAULT_NCS_DEVICE_INFO_BUILTIN was missed. The migration guide already has this change, so this commit just aligns the code with the migration guide.