Repository navigation
Fix the rough edges of running proof - #9
Merged
Merged
Conversation
wire.error-terminal failed on any key but a few after an error status, so Babashka's changed-namespaces, which arrives after done, failed it. REPLy and rebel-readline stop reading a request at an error, but all they'd lose is output, values and need-input, so that's what the rule looks for now. The late message is still wire.after-done's warning.
proof serve -like already took a server's name, but run and proxy wanted a file, and people who install proof with go install don't have the profiles folder at all. The profiles are now embedded in the binary, and the name of one of them means that profile, while anything else is the path of a profile.
The flag package stops at the first argument that isn't a flag, so proof run profiles/x.toml -only 'eval.*' complained that it expected one profile, and proof serve refused flags after a scenario. Each command now parses its flags wherever they are, and -h shows how to use it rather than Go's bare "Usage of run:".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled profiles are now in the binary, so
proof run babashkaworks aftergo installtoo. A bundled name wins over a file with the same name in the current directory, which./babashkastill reaches.