Repository navigation
Conversation
A server that goes down at a frame it can't read takes every client with it, and a session that stops answering takes a REPL along. The new checks send frames that aren't requests (on connections the wire rules don't grade, as no reply to them can be right), an eval with line as a string, and interrupt an eval whose client went away, and look at whether the server and the session keep answering. One more makes sure an eval in one session doesn't hold up the others. nREPL 1.8.0 never answers the eval with the wrong types (nrepl#477) and, after a client went away in the middle of an eval, never sends the done of the next eval in that session. Babashka hangs on the wrong types too, and a bencode string takes jank down.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These run last, since a server that fails them may not be around for the next check. robust.wrong-types is only a warning, as no client we know of sends fields of the wrong type, but a request that never gets done fails it anyway, which is what happens with nREPL.