Repository navigation
Conversation
CIDER, Calva, Conjure and vim-fireplace complete code and look symbols up with nREPL's completions and lookup or cider-nrepl's complete, info and eldoc, each with its own parameters and its own way of reading the replies. The new checks send what each of them sends to whichever of those ops a server lists, and fail where a client breaks: completions that aren't in the message with done, candidates that aren't dicts, info without no-info for a symbol that doesn't exist (which takes CIDER's docs down), columns counting from 0, files that aren't URIs. The checks of completions and lookup skip when the server also has complete and info, as clients use those instead. proof serve gets nREPL's completions and lookup for its piece of Clojure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clients use complete and info when a server has them, so the completions and lookup checks skip then.
-likedoesn't reproduce other servers' completions and lookups, so the matrix test leaves them out.