feat: add "create new account" button to PDS page#3022
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Hello! Thank you for opening your first PR to npmx, @ascorbic! 🚀 Here’s what will happen next:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis PR adds a create-account action to the PDS page, with a new button, redirect handler, translation string, and locale schema entry. ChangesPDS create account flow
Sequence Diagram(s)sequenceDiagram
participant User
participant PdsPage
participant AuthRedirect
participant NpmxSocial
User->>PdsPage: Click "Create a new account"
PdsPage->>AuthRedirect: authRedirect(npmx.social, create:true, redirect, locale)
AuthRedirect->>NpmxSocial: Redirect with create + locale params
NpmxSocial-->>PdsPage: Redirect back to route.fullPath
Possibly related issues
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
#3021
🧭 Context
The current /pds page only has a link to PDS MOOver, with no way to directly create a new account. To create a new account (rather than migrating) a user needs to open the "Connect" menu, select "Connect to Atmosphere", then click the button in the modal.
📚 Description
This PR adds a button alongside the PDS Moover one that calls
authRedirectin the same way as the equivalent in the modal.