Skip to content

feat: add "create new account" button to PDS page#3022

Open
ascorbic wants to merge 2 commits into
npmx-dev:mainfrom
ascorbic:pds-create-account
Open

feat: add "create new account" button to PDS page#3022
ascorbic wants to merge 2 commits into
npmx-dev:mainfrom
ascorbic:pds-create-account

Conversation

@ascorbic

@ascorbic ascorbic commented Jul 8, 2026

Copy link
Copy Markdown

🔗 Linked issue

#3021

🧭 Context

The current /pds page only has a link to PDS MOOver, with no way to directly create a new account. To create a new account (rather than migrating) a user needs to open the "Connect" menu, select "Connect to Atmosphere", then click the button in the modal.

📚 Description

This PR adds a button alongside the PDS Moover one that calls authRedirect in the same way as the equivalent in the modal.

@vercel

vercel Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 8, 2026 12:47pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 8, 2026 12:47pm
npmx-lunaria Ignored Ignored Jul 8, 2026 12:47pm

Request Review

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Hello! Thank you for opening your first PR to npmx, @ascorbic! 🚀

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@coderabbitai

coderabbitai Bot commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 12273ecb-0acd-4196-9683-791f1c3e0446

📥 Commits

Reviewing files that changed from the base of the PR and between c93ffc0 and a1fed0a.

📒 Files selected for processing (1)
  • i18n/schema.json

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Added a new “Create account” option on the PDS page alongside existing join and migrate actions.
    • Account creation now returns people to their current page after sign-up, preserving the selected language.
  • Documentation
    • Updated English interface text with the new “Create account” label for the PDS join section.
  • Chores
    • Extended the i18n schema and locale definitions to support the new translation string.

Walkthrough

This PR adds a create-account action to the PDS page, with a new button, redirect handler, translation string, and locale schema entry.

Changes

PDS create account flow

Layer / File(s) Summary
Create account handler and button wiring
app/pages/pds.vue, i18n/locales/en.json
Adds handleCreateAccount, which calls authRedirect for https://npmx.social with account creation enabled, current route redirect, and locale; wires a new primary ButtonBase in the join section to this handler; adds the pds.join.create_account translation key ("Create a new account").
Locale schema field
i18n/schema.json
Adds the pds.join.create_account string property to the locale schema.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant PdsPage
  participant AuthRedirect
  participant NpmxSocial

  User->>PdsPage: Click "Create a new account"
  PdsPage->>AuthRedirect: authRedirect(npmx.social, create:true, redirect, locale)
  AuthRedirect->>NpmxSocial: Redirect with create + locale params
  NpmxSocial-->>PdsPage: Redirect back to route.fullPath
Loading

Possibly related issues

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: adding a new account creation button to the PDS page.
Description check ✅ Passed The description accurately describes the new button on the /pds page and its authRedirect behaviour.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant