fix(ui): consistent terminal box height across package managers#3018
fix(ui): consistent terminal box height across package managers#3018kpab wants to merge 1 commit into
Conversation
…nsistent across package managers
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
Hello! Thank you for opening your first PR to npmx, @kpab! 🚀 Here’s what will happen next:
|
📝 WalkthroughWalkthroughThe command-container spacing in Terminal Execute.vue and Install.vue is changed from ChangesTerminal box spacing fix
Related issues: Estimated code review effort: Low 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
Fixes #3016
🧭 Context
Every package manager's command variant stays in the DOM and is shown/hidden with CSS. The container used
space-y-1, which only adds spacing to items that aren't the last child. The last PM in the list (nub) is always the structurally-last child, so when you select it, it loses its bottom margin and its command box renders ~4px shorter than the others.📚 Description
Swapped
space-y-1forflex flex-col gap-1on the command containers inTerminal/Install.vueandTerminal/Execute.vue.gaponly spaces items that are actually rendered, so the hidden variants no longer affect the height and every PM's box is the same size. Visible spacing is unchanged.Checked with
pnpm lint,pnpm test:typesandpnpm test(all passing). No new test — the bug lives in the generated CSS layout, which Vitest doesn't render.📸 Screenshots
Before: non-last package managers rendered slightly taller than the last package manager (
nub).After:
npmandnubrender with the same terminal box height.