Skip to content

fix: package code viewer overscroll#3015

Open
ghostdevv wants to merge 1 commit into
mainfrom
w/overscroll
Open

fix: package code viewer overscroll#3015
ghostdevv wants to merge 1 commit into
mainfrom
w/overscroll

Conversation

@ghostdevv

@ghostdevv ghostdevv commented Jul 7, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

🧭 Context

Fixes weird overscroll that is highlighted by #1977

📚 Description

Before: After:
image image

I tried to fix this too but I failed, it's such a delicate balance of styles here

Current: Ideal:
image image

@vercel

vercel Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 7, 2026 3:03am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Jul 7, 2026 3:03am
npmx-lunaria Ignored Ignored Jul 7, 2026 3:03am

Request Review

@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The desktop sidebar containing the file tree on the package code page was updated to use full-viewport height (h-screen) instead of a calculated height offset, with scrolling applied to an inner container.

Changes

Sidebar Sizing Update

Layer / File(s) Summary
Sidebar height and scroll container
app/pages/package-code/[[org]]/[packageName]/v/[version]/[...filePath].vue
Changed the aside and its inner scroll container from h-[calc(100vh-10.5rem)] sizing to h-screen with overflow-y-auto on the inner scroll div.

Related Issues: None specified.

Related PRs: None specified.

Suggested labels: ui, low-effort

Suggested reviewers: None specified.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: fixing overscroll in the package code viewer.
Description check ✅ Passed The description is directly related to the overscroll fix and its before/after visual context.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch w/overscroll

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ghostdevv ghostdevv marked this pull request as ready for review July 7, 2026 03:04
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant