revert: revert "fix: consistent and likely safer regex escaping"#2403
Merged
revert: revert "fix: consistent and likely safer regex escaping"#2403
Conversation
This reverts commit 42fc173.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
fatfingers23
approved these changes
Apr 6, 2026
Contributor
|
based |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1439
main.npmx.dev and all new previews are broken at the moment. I bisected all the commits on main (https://github.com/npmx-dev/npmx.dev/pull/2354/commits) and this was unambiguously the culprit.
See also https://discord.com/channels/1464542801676206113/1490833925759701235.
I don't have access to the server logs, so I'm running blind here. Just reverting for now.
Repro 1
Visit
/astro, see Vercel 500 crash page.Repro 2
Visit
/package/astro, see a dozen pieces of data "degrade gracefully".