Skip to content

feat: add link to socket.dev#2370

Draft
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:socket.dev
Draft

feat: add link to socket.dev#2370
gameroman wants to merge 1 commit intonpmx-dev:mainfrom
gameroman:socket.dev

Conversation

@gameroman
Copy link
Copy Markdown
Contributor

🔗 Linked issue

Closes #2369

🧭 Context

Similar to what npmjs has

image

📚 Description

Adds link to socket.dev

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 3, 2026 0:13am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 3, 2026 0:13am
npmx-lunaria Ignored Ignored Apr 3, 2026 0:13am

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e374ed31-b6f9-4d08-8f5a-2e7f07fab54d

📥 Commits

Reviewing files that changed from the base of the PR and between 1d1f450 and 0171632.

📒 Files selected for processing (1)
  • app/components/Package/ExternalLinks.vue

📝 Walkthrough

Walkthrough

This pull request adds a new external link to the ExternalLinks.vue component that directs users to socket.dev for the corresponding npm package. The change introduces a LinkBase component rendering to https://socket.dev/npm/package/${pkg.name} with the label socket.dev and uses localisation support via $t('common.view_on.socket_dev'). The modification is purely additive with no changes to existing link entries or conditional rendering logic.

Possibly related PRs

Suggested reviewers

  • graphieros
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly describes adding a link to socket.dev, which is directly related to the changeset that adds a new external link entry.
Linked Issues check ✅ Passed The pull request implements the core requirement from issue #2369 by adding a socket.dev link entry to ExternalLinks.vue, mirroring npmjs.com's integration.
Out of Scope Changes check ✅ Passed All changes are scoped to adding the socket.dev link entry as required; no unrelated modifications are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

<li>
<LinkBase
:to="`https://socket.dev/npm/package/${pkg.name}`"
:title="$t('common.view_on.socket_dev')"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there doesn't seem to be a translation for this in english?

<li>
<LinkBase
:to="`https://socket.dev/npm/package/${pkg.name}`"
:title="$t('common.view_on.socket_dev')"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we add the icon for it as a shield or smth, so it's more consistent? currently it's the only thing with the link external icon

Image

@gameroman gameroman marked this pull request as draft April 4, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add links to socket.dev

2 participants