Skip to content

Conversation

@iiio2
Copy link
Contributor

@iiio2 iiio2 commented Feb 10, 2026

Look, our engines in vitest is really long. For that reason the package name is not visible in mobile version due to long values. I think we can improve it.

Before:
wrong

After:
correct

@vercel
Copy link

vercel bot commented Feb 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 10, 2026 5:25pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 10, 2026 5:25pm
npmx-lunaria Ignored Ignored Feb 10, 2026 5:25pm

Request Review

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

📝 Walkthrough

Walkthrough

The pull request modifies layout classes in the FacetCard component. Specifically, two spans within the component have their CSS class assignments adjusted to alter flex shrinking and width constraints. The package name span transitions from a flex-shrink configuration with minimum width constraint to a no-shrink state. The value container span changes from a flex-shrink-0 setup to a minimum width constraint combined with text-end alignment. These modifications affect horizontal space distribution and text positioning without altering the component's rendering logic, data processing, or conditional behaviour.

Suggested reviewers

  • danielroe
  • whitep4nth3r
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Description check ✅ Passed The pull request description clearly explains the issue (package names not visible due to long values) and includes before/after screenshots demonstrating the layout fix.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

No actionable comments were generated in the recent review. 🎉

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.


Comment @coderabbitai help to get the list of available commands and usage tips.

@43081j 43081j added this pull request to the merge queue Feb 10, 2026
Merged via the queue into npmx-dev:main with commit efcdbac Feb 10, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants