Skip to content

Conversation

@jellydeck
Copy link
Contributor

@jellydeck jellydeck commented Feb 7, 2026

update the general style of buttons, group buttons and links to be consistent with our design language.

also, removed global css as Input component seems to be done.
Thanks @alexdln @essenmitsosse for feedback, enjoyed working together :)

@vercel
Copy link

vercel bot commented Feb 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Feb 11, 2026 0:06am
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Feb 11, 2026 0:06am
npmx-lunaria Ignored Ignored Feb 11, 2026 0:06am

Request Review

@vercel
Copy link

vercel bot commented Feb 7, 2026

@jellydeck is attempting to deploy a commit to the serhalp's projects Team on Vercel.

A member of the Team first needs to authorize it.

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/components/Header/AccountMenu.client.vue 80.00% 1 Missing ⚠️
app/pages/package/[[org]]/[name].vue 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thasmo
Copy link
Contributor

thasmo commented Feb 8, 2026

  1. focus ring is not in foreground
image
  1. accent color is not used on some elements
image image image
  1. cut off focus-ring (same on prod)
image

@jellydeck
Copy link
Contributor Author

  1. focus ring is not in foreground
image
2. accent color is not used on some elements

image image image

3. cut off focus-ring (same on prod)
image

done 👍

@jellydeck
Copy link
Contributor Author

Screenshot 2026-02-09 at 13 28 25

There is a regression here, where the menu links/buttons have their outline back. This should be overwritten (see prod)

done in latest commit 👍

@essenmitsosse
Copy link
Contributor

by the way your screenshots are not showing for me

@jellydeck
Copy link
Contributor Author

by the way your screenshots are not showing for me

can you quote that reply?

@essenmitsosse
Copy link
Contributor

by the way your screenshots are not showing for me

can you quote that reply?

These: #1163 (comment) + #1163 (comment)

@jellydeck
Copy link
Contributor Author

#1163 (comment) is quote reply to this comment #1163 (comment)

#1163 (comment) is
547088109-bea84a9b-6590-482e-a4e7-6379a1fc2ebf

both are quote reply, i didn't upload any ss myself.

@essenmitsosse
Copy link
Contributor

Ah you're right. Still weird it doesn't show the images though. But never mind.

@essenmitsosse
Copy link
Contributor

@jellydeck FYI: there is now also a styled link in the css in Readme.vue. For now we need to keep this in sync with the style from LinkBase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants