fix: premajor/preminor/prepatch should respect prerelease status - #892
Open
marceli1404 wants to merge 1 commit into
Open
fix: premajor/preminor/prepatch should respect prerelease status#892marceli1404 wants to merge 1 commit into
marceli1404 wants to merge 1 commit into
Conversation
…#751) premajor, preminor, and prepatch now delegate to their non-pre counterparts (major/minor/patch) first, which correctly handle the case where the version is already a prerelease. Previously they would unconditionally bump the version number, even when the current version is a prerelease at x.0.0-something. Behavior change: prepatch on a prerelease no longer bumps patch (e.g., 1.2.0-1 → prepatch → 1.2.0-0 instead of 1.2.1-0), which is consistent with how patch strips the prerelease without bumping.
Author
|
Friendly bump — this fixes #751 where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #751
\premajor, \preminor, and \prepatch\ now delegate to their non-pre counterparts (\major/\minor/\patch) first, which correctly handle the case where the version is already a prerelease.
Root Cause
Previously, the pre-* increment operations would unconditionally bump the version number, even when the current version was a prerelease of the same major/minor/patch.
For example:
Fix
\premajor\ now calls \inc('major')\ (which checks if the version is already at \x.0.0\ with a prerelease before bumping), then \inc('pre'). Same pattern for \preminor\ and \prepatch.
Test Changes
Updated 6 test expectations that reflected the old buggy behavior:
All 51 existing tests pass with 100% coverage.