Fix color of header icons in mobile dark mode#1949
Open
Fix color of header icons in mobile dark mode#1949
Conversation
Contributor
|
Nice initiative and solution @eggplants however the maintainers would reject your PR due to the induced changes in the package-lock.json. |
Contributor
|
Yes, please remove lockfile changes, then I can review this. |
Author
|
@owlstronaut The README.md and CONTRIBUTING.md files instruct users to run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed an issue where the Search/Menu buttons in the mobile header appeared black in Dark Mode.
Also, since
package-lock.jsonwas updated when I rannpm i, I've included it.Like the Drawer's
.Box_3, it inherits the foreground color of the parent container to ensure that all buttons are displayed in white.documentation/src/components/nav-drawer.module.css
Lines 26 to 32 in e93dc35
References
Fixes #1948