Skip to content

Fix color of header icons in mobile dark mode#1949

Open
eggplants wants to merge 2 commits intonpm:mainfrom
eggplants:fix-1948
Open

Fix color of header icons in mobile dark mode#1949
eggplants wants to merge 2 commits intonpm:mainfrom
eggplants:fix-1948

Conversation

@eggplants
Copy link
Copy Markdown

I've fixed an issue where the Search/Menu buttons in the mobile header appeared black in Dark Mode.

Also, since package-lock.json was updated when I ran npm i, I've included it.

Before After
Screenshot 2026-04-23 at 20 09 43 Screenshot 2026-04-23 at 20 09 16

Like the Drawer's .Box_3, it inherits the foreground color of the parent container to ensure that all buttons are displayed in white.

.Box_3 {
display: flex;
flex-direction: column;
flex: 1 0 auto;
color: #e1e4e8;
background: #333333;
}

image

References

Fixes #1948

@eggplants eggplants requested review from a team and leobalter as code owners April 23, 2026 11:15
@kenshanta
Copy link
Copy Markdown
Contributor

Nice initiative and solution @eggplants however the maintainers would reject your PR due to the induced changes in the package-lock.json.
My advice would be to revert the lockfile changes for a higher chance to have the PR merged.
Cheers!

@owlstronaut
Copy link
Copy Markdown
Contributor

Yes, please remove lockfile changes, then I can review this.

@eggplants
Copy link
Copy Markdown
Author

@owlstronaut The README.md and CONTRIBUTING.md files instruct users to run npm install first, but you said to “remove changes to the lockfile.” I'm not quite sure why those files specify npm install instead of npm ci.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile header icons are hard to see

3 participants