Skip to content

fix: respect custom viewer in npm help #9829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
happykawayigt wants to merge 1 commit into
base: latest
Choose a base branch
from
+13 −1
Draft

fix: respect custom viewer in npm help #9829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/commands/help.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ class Help extends BaseCommand {
return openUrl(this.npm, this.htmlMan(man), 'help available at the following URL', true)
}

let args = ['man', [man]]
let args = [viewer, [man]]
if (viewer === 'woman') {
args = ['emacsclient', ['-e', `(woman-find-file '${man}')`]]
}
Expand Down
12 changes: 12 additions & 0 deletions test/lib/commands/help.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,18 @@ t.test('npm help whoami', async t => {
t.match(spawnArgs[0], /npm-whoami\.1$/)
})

t.test('npm help with custom viewer', async t => {
const { getArgs } = await mockHelp(t, {
exec: ['whoami'],
config: { viewer: 'batman' },
})

const [spawnBin, spawnArgs] = getArgs()
t.equal(spawnBin, 'batman', 'calls the configured viewer')
t.equal(spawnArgs.length, 1)
t.match(spawnArgs[0], /npm-whoami\.1$/)
})

t.test('npm help 1 install', async t => {
const { getArgs } = await mockHelp(t, {
exec: ['1', 'install'],
Expand Down