fix: preserve script output lacking a final newline#9171
Open
priyanshurav wants to merge 1 commit intonpm:latestfrom
Open
fix: preserve script output lacking a final newline#9171priyanshurav wants to merge 1 commit intonpm:latestfrom
priyanshurav wants to merge 1 commit intonpm:latestfrom
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If the script output did not end with a newline, then the last line that was printed to the console would get deleted,
This was due to the
#clearSpinnermethod inProgressclass deleting an entire line, just to erase the spinner.Solution
Used control characters to only erase the single spinner character and not the entire line.
References
Fixes #8583