Repository navigation
Fix text conversions of a space char, Convert.ToString(bool) and a null string.Join separator - #4137
Open
efeesrefinal wants to merge 1 commit into
Open
efeesrefinal wants to merge 1 commit into
efeesrefinal wants to merge 1 commit into
Conversation
…), match Convert.ToString(bool) and a null string.Join separator Fixes npgsql#4096
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4096
charcolumn or parameter ischaracter(1), and converting it to text strips a space.string.Join,PadLeft/PadRightandchar.ToString()now go through the samerpad(x, 1)handling that Translate string methods with char arguments #4001 added forIndexOf.Convert.ToString(bool)returnedtrue/false; it now returnsTrue/Falselikebool.ToString(), and stays NULL for a NULL argument.string.Jointreats a null separator as empty, so the separator is wrapped inCOALESCE(separator, '')unless it is a non-null constant or a non-nullable column.The six new tests fail on main.
Compare_timestamp_column_to_local_DateTime_parameterfails in my Linux container on main as well and is unrelated.