Repository navigation
Treat a JSON array element as nullable when setting a JSON property from it - #4136
Open
efeesrefinal wants to merge 1 commit into
Open
efeesrefinal wants to merge 1 commit into
efeesrefinal wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4097
ExecuteUpdateusesjsonb_setinstead ofjsonb_set_laxwhen the value cannot be NULL. A JSON array element was judged by the nullability of its element type, but an out-of-range index yields NULL whatever that type is, sojsonb_setreceived NULL and returned NULL for the whole document.MayReturnNullnow returns true for aJsonScalarExpressionwhose path contains an array index. The property becomes a JSON null and the rest of the document is kept. Before PostgreSQL 16 the same check adds the existingCOALESCEto a JSON null; I only ran this against PostgreSQL 18, so that path is untested.The new test
Update_property_to_out_of_range_primitive_collection_elementfails on main with a not-null violation (23502). The*BulkUpdate*and*Json*test classes pass against PostgreSQL 18.