Repository navigation
Document EF 11 JSON member indexes - #474
Merged
Merged
Conversation
Add JSON mapping examples and index selection guidance, with an EF 11 release-note entry and temporary RC2 limitations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8e44980c-ccf7-431f-bc01-da8135db9db0
There was a problem hiding this comment.
🟢 Approval recommended
The documentation matches the accompanying implementation and documented limitations, with no unresolved findings.
0 open findings
What changed in this PR
Documents EF 11 JSON member indexing alongside the provider’s JSON mapping guidance.
Changes:
- Replaces the indexing placeholder with examples, B-tree and GIN guidance, and supported paths and limitations.
- Adds a release-note entry, keeping temporary RC2 limitations separate from the main guidance.
| File | Description |
|---|---|
| conceptual/EFCore.PG/release-notes/11.0.md | Announces JSON member indexing and explains temporary RC2 limitations. |
| conceptual/EFCore.PG/mapping/json.md | Adds indexing examples, index-selection guidance, and limitations. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document JSON member indexing alongside the JSON mapping guidance rather than in the provider's package README. This accompanies the provider work for npgsql/efcore.pg#2568 and npgsql/efcore.pg#3918.
Replace the indexing placeholder with examples using the existing Customer model, explain targeted B-tree indexes versus whole-document and targeted GIN indexes, and describe supported paths and limitations. Add a short EF 11 release-note entry linking to the guidance, keeping the temporary RC2 migration-scaffolding and mixed-sort-direction limitations separate from the long-lived documentation.