test: use shared IPv4 loopback host instead of localhost#5277
Closed
trivikr wants to merge 3 commits intonodejs:mainfrom
Closed
test: use shared IPv4 loopback host instead of localhost#5277trivikr wants to merge 3 commits intonodejs:mainfrom
trivikr wants to merge 3 commits intonodejs:mainfrom
Conversation
Assisted-by: openai:gpt-5.5 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Member
Author
|
Discarding as there are too many test failures |
Member
Author
|
For future reference, this PR was attempted as gpt-5.5 gave the following reason
If any other undici maintainer wants to take over (chrry-pick or post new PR altogether), I'll be happy to review if it can help reduce flaky test failures on Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
Relates to #5177
Rationale
Windows CI has intermittent failures around tests using
localhost.On Windows, localhost resolution can prefer IPv6 (
::1) or otherwise depend on hosts/DNS behavior, while some tests bind/connect through IPv4 loopback. Using127.0.0.1removes name-resolution ambiguity and keeps the test server/client address family consistent.Changes
Centralizes the test loopback host as
LOOPBACK_HOSTand updates first-party tests to use it instead of inlinelocalhost/127.0.0.1where appropriate.Features
N/A
Bug Fixes
Breaking Changes and Deprecations
Status
Assisted-by: openai:gpt-5.5