Skip to content

fix(ui-components): add Search storybook examples and support rich hit descriptions - #9163

Open
btea wants to merge 1 commit into
nodejs:mainfrom
btea:feat/search-storybook-code-description
Open

btea wants to merge 1 commit into
nodejs:mainfrom
btea:feat/search-storybook-code-description

Conversation

@btea

@btea btea commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Description

image

The description content in the search results of the search box shown in the figure also includes backtick characters. We can change it to support tag rendering to make the display results more intuitive.

Validation

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run pnpm format to ensure the code follows the style guide.
  • I have run pnpm test to check if all tests are passing.
  • I have run pnpm build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@btea
btea requested a review from a team as a code owner September 18, 2026 01:31
Copilot AI lite review requested due to automatic review settings September 18, 2026 01:31
@vercel

vercel Bot commented Sep 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nodejs-org Ready Ready Preview Sep 18, 2026 1:32am UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Sep 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.07%. Comparing base (f50e151) to head (10add16).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9163      +/-   ##
==========================================
- Coverage   86.08%   86.07%   -0.02%     
==========================================
  Files          86       86              
  Lines        6046     6046              
  Branches      358      358              
==========================================
- Hits         5205     5204       -1     
- Misses        837      838       +1     
  Partials        4        4              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@AugustinMauroy AugustinMauroy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem good could you provide a screenshot of storybook ? cc @nodejs/web-infra why chromatic didn't work ?

@github-actions

Copy link
Copy Markdown
Contributor

📦 Build Size Comparison

Summary

Metric Value
Old Total First Load JS 7.10 MB
New Total First Load JS 7.10 MB
Delta -68.00 B (-0.00%)

Changes

🔄 Modified Routes (4)
Route Old First Load JS New First Load JS Delta
/[locale] 1.67 MB 1.67 MB 📉 -17.00 B (-0.00%)
/[locale]/[...path] 1.67 MB 1.67 MB 📉 -17.00 B (-0.00%)
/[locale]/blog/[...path] 1.67 MB 1.67 MB 📉 -17.00 B (-0.00%)
/[locale]/download/archive/[version] 1.67 MB 1.67 MB 📉 -17.00 B (-0.00%)

@btea

btea commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

seem good could you provide a screenshot of storybook ?

image

The screenshot is shown above. However, the code here is not nested within the main tag, so the background color style does not match. Even if it did match, the background color of the code would be consistent with the background color of the item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants