Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
👋 Codeowner Review RequestThe following codeowners have been identified for the changed files: Team reviewers: @nodejs/nodejs-website @nodejs/web-infra Please review the changes when you have a chance. Thank you! 🙏 |
|
Vercel is not enjoying this git-hosted dependency, it seems. So, this is blocked by nodejs/doc-kit#624. |
There was a problem hiding this comment.
Pull request overview
This PR bumps the @nodejs/doc-kit dependency used by the @node-core/remark-lint package to a newer git commit so future remark-lint rules can rely on updated doc-kit logic (e.g., more accurate regexes).
Changes:
- Update
@nodejs/doc-kitgit SHA inpackages/remark-lint/package.json. - Regenerate
pnpm-lock.yamlto reflect the new doc-kit commit and its updated dependency graph.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
packages/remark-lint/package.json |
Updates the doc-kit git reference used by the remark-lint package. |
pnpm-lock.yaml |
Updates the lockfile to match the new doc-kit commit and its transitive dependencies. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "dependencies": { | ||
| "@nodejs/doc-kit": "github:nodejs/doc-kit#be7fc307395005ea362d035c43e3818650bf075f", | ||
| "@nodejs/doc-kit": "github:nodejs/doc-kit#439cfad4c1c20e90132837079f6439913244907d", | ||
| "remark-gfm": "^4.0.1", |
There was a problem hiding this comment.
The updated @nodejs/doc-kit commit pulls in new transitive peer dependencies (e.g. jiti, postcss, react, react-dom, tsx, @orama/core). Since @node-core/remark-lint doesn’t declare these as dependencies/peerDependencies, consumers installing this package outside the monorepo may get unmet peer warnings or runtime resolution failures depending on which parts of doc-kit are imported. Consider explicitly adding the required peers to this package (as dependencies or peerDependencies with appropriate ranges), or switching to a smaller doc-kit entrypoint/package that doesn’t require these peers.
📦 Build Size ComparisonSummary
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8694 +/- ##
==========================================
+ Coverage 75.05% 75.10% +0.04%
==========================================
Files 104 104
Lines 9161 9161
Branches 316 315 -1
==========================================
+ Hits 6876 6880 +4
+ Misses 2283 2279 -4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Until nodejs/doc-kit#624 is complete, unfortunately, Dependabot will not be able to update
doc-kitin this repository.I'd like to implement additional rules relying on newer versions of doc-kit (for more accurate RegExps), and to do that, I need to bump doc-kit.
Given that the bump itself is a substantial change (since this version hasn't been updated in a very long time), I'm making this it's own PR.