Skip to content

chore(deps): bump doc-kit in remark-lint#8694

Draft
avivkeller wants to merge 1 commit intomainfrom
bump-doc-kit
Draft

chore(deps): bump doc-kit in remark-lint#8694
avivkeller wants to merge 1 commit intomainfrom
bump-doc-kit

Conversation

@avivkeller
Copy link
Member

Until nodejs/doc-kit#624 is complete, unfortunately, Dependabot will not be able to update doc-kit in this repository.

I'd like to implement additional rules relying on newer versions of doc-kit (for more accurate RegExps), and to do that, I need to bump doc-kit.

Given that the bump itself is a substantial change (since this version hasn't been updated in a very long time), I'm making this it's own PR.

@avivkeller avivkeller requested review from a team as code owners March 4, 2026 21:54
Copilot AI review requested due to automatic review settings March 4, 2026 21:54
@vercel
Copy link

vercel bot commented Mar 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
nodejs-org Error Error Mar 4, 2026 9:58pm

Request Review

@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website @nodejs/web-infra

Please review the changes when you have a chance. Thank you! 🙏

@avivkeller
Copy link
Member Author

Vercel is not enjoying this git-hosted dependency, it seems. So, this is blocked by nodejs/doc-kit#624.

Error: Command "pnpm install --prod" exited with SIGKILL
Error: pnpm install failed with SIGKILL. There may be unexpected items in the build cache. Try redeploying without the build cache. Learn More: https://vercel.com/docs/deployments/managing-deployments#redeploy-a-project

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR bumps the @nodejs/doc-kit dependency used by the @node-core/remark-lint package to a newer git commit so future remark-lint rules can rely on updated doc-kit logic (e.g., more accurate regexes).

Changes:

  • Update @nodejs/doc-kit git SHA in packages/remark-lint/package.json.
  • Regenerate pnpm-lock.yaml to reflect the new doc-kit commit and its updated dependency graph.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/remark-lint/package.json Updates the doc-kit git reference used by the remark-lint package.
pnpm-lock.yaml Updates the lockfile to match the new doc-kit commit and its transitive dependencies.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 22 to 24
"dependencies": {
"@nodejs/doc-kit": "github:nodejs/doc-kit#be7fc307395005ea362d035c43e3818650bf075f",
"@nodejs/doc-kit": "github:nodejs/doc-kit#439cfad4c1c20e90132837079f6439913244907d",
"remark-gfm": "^4.0.1",
Copy link

Copilot AI Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated @nodejs/doc-kit commit pulls in new transitive peer dependencies (e.g. jiti, postcss, react, react-dom, tsx, @orama/core). Since @node-core/remark-lint doesn’t declare these as dependencies/peerDependencies, consumers installing this package outside the monorepo may get unmet peer warnings or runtime resolution failures depending on which parts of doc-kit are imported. Consider explicitly adding the required peers to this package (as dependencies or peerDependencies with appropriate ranges), or switching to a smaller doc-kit entrypoint/package that doesn’t require these peers.

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 4, 2026

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.51 MB
New Total Size 3.51 MB
Delta 0 B (0.00%)

@codecov
Copy link

codecov bot commented Mar 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.10%. Comparing base (7c0ef4a) to head (3a9f09d).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8694      +/-   ##
==========================================
+ Coverage   75.05%   75.10%   +0.04%     
==========================================
  Files         104      104              
  Lines        9161     9161              
  Branches      316      315       -1     
==========================================
+ Hits         6876     6880       +4     
+ Misses       2283     2279       -4     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants