Skip to content

Conversation

@avivkeller
Copy link
Member

Closes #8525.

DevBox does not meet our guidelines, as it is not a FOSS product.

Copilot AI review requested due to automatic review settings January 8, 2026 22:25
@avivkeller avivkeller requested a review from a team as a code owner January 8, 2026 22:25
@vercel
Copy link

vercel bot commented Jan 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
nodejs-org Ready Ready Preview Jan 8, 2026 10:26pm

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

👋 Codeowner Review Request

The following codeowners have been identified for the changed files:

Team reviewers: @nodejs/nodejs-website

Please review the changes when you have a chance. Thank you! 🙏

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.83%. Comparing base (274f68a) to head (d338623).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...i-components/src/Icons/InstallationMethod/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8527      +/-   ##
==========================================
+ Coverage   74.69%   74.83%   +0.13%     
==========================================
  Files         102      101       -1     
  Lines        8956     8924      -32     
  Branches      305      304       -1     
==========================================
- Hits         6690     6678      -12     
+ Misses       2264     2244      -20     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes DevBox as an installation method from the Node.js website because DevBox does not meet the project's FOSS (Free and Open Source Software) guidelines.

Key changes:

  • Removed DevBox icon component and all references from UI components
  • Removed 'DEVBOX' from the InstallationMethod type definition
  • Deleted DevBox installation snippets across all 13 supported languages
  • Removed DevBox localization strings from all applicable language files

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/ui-components/src/Icons/InstallationMethod/index.ts Removed DevBox import and export from installation method icons
packages/ui-components/src/Icons/InstallationMethod/Devbox.tsx Deleted DevBox icon component
packages/ui-components/design/platform-logos.stories.tsx Removed DevBox from Storybook stories
apps/site/types/release.ts Removed 'DEVBOX' from InstallationMethod type union
apps/site/util/download/constants.json Removed DevBox configuration entry from installMethods array
packages/i18n/src/locales/*.json Removed DevBox description from 11 language files (en, fr, id, ja, ko, pt, pt-br, ro, uk, zh-cn, zh-tw)
apps/site/snippets/*/download/devbox.bash Deleted DevBox installation snippets for 13 languages (en, es, fr, id, ja, ko, pt, pt-br, ro, tr, uk, zh-cn, zh-tw)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

📦 Build Size Comparison

Summary

Metric Value
Old Total Size 3.74 MB
New Total Size 3.74 MB
Delta -3.66 KB (-0.10%)

Changes

➕ Added Assets (4)
Name Size
.next/static/chunks/addd19b536edb0f5.js 205.09 KB
.next/static/chunks/81ac9107cf577dfe.js 29.26 KB
.next/static/chunks/65a9507fbb36b2b2.js 562.13 KB
.next/static/chunks/f6a569646a6e2497.js 562.13 KB
➖ Removed Assets (4)
Name Size
.next/static/chunks/aa3451220184e985.js 205.09 KB
.next/static/chunks/9c5b84cf73fa1b5b.js 29.42 KB
.next/static/chunks/25e24e3f3b057667.js 563.88 KB
.next/static/chunks/7e844f9aaf3c585b.js 563.88 KB

Copy link
Member

@araujogui araujogui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avivkeller avivkeller added this pull request to the merge queue Jan 10, 2026
Merged via the queue into main with commit d394514 Jan 10, 2026
20 checks passed
@avivkeller avivkeller deleted the devbox branch January 10, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants