Skip to content

crypto: update root certificates to NSS 3.131.1 - #66877

Merged
aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:update-root-certs
Oct 20, 2026
Merged

aduh95 merged 1 commit into
nodejs:mainfrom
aduh95:update-root-certs

Conversation

@aduh95

@aduh95 aduh95 commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

This is the certdata.txt1 from NSS 3.131.1.

Certificates removed:

  • emSign ECC Root CA - G3
  • emSign Root CA - C1
  • emSign ECC Root CA - C3

Refs: https://groups.google.com/a/mozilla.org/g/dev-tech-crypto/c/vSxZxnOMMvs

This update is not yet available in a Firefox release, so the bot wasn't able to pick it up. I used the following diff to force the script to pick it up:

diff --git a/tools/dep_updaters/update-root-certs.mjs b/tools/dep_updaters/update-root-certs.mjs
index 80b6fb33f74..c185bb5d8e7 100644
--- a/tools/dep_updaters/update-root-certs.mjs
+++ b/tools/dep_updaters/update-root-certs.mjs
@@ -115,9 +115,9 @@ if (values.help) {
   process.exit(0);
 }
 
-const firefoxRelease = await getFirefoxRelease(positionals[0]);
+const firefoxRelease = null;
 // Retrieve metadata for the NSS release being updated to.
-const version = await getNSSVersion(firefoxRelease);
+const version = '3.131.1';
 if (values.verbose) {
   console.log(`Updating to NSS version ${version}`);
 }

Footnotes

  1. https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_131_1_RTM/lib/ckfw/builtins/certdata.txt a749e413-a6b5-45ca-827d-a943355e84c8 ↩

This is the certdata.txt[0] from NSS 3.131.1.

Certificates removed:
- emSign ECC Root CA - G3
- emSign Root CA - C1
- emSign ECC Root CA - C3

[0] https://raw.githubusercontent.com/nss-dev/nss/refs/tags/NSS_3_131_1_RTM/lib/ckfw/builtins/certdata.txt
a749e413-a6b5-45ca-827d-a943355e84c8
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tls Issues and PRs related to the tls subsystem. tools Issues and PRs related to the tools directory. labels Oct 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@UlisesGascon UlisesGascon added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label Oct 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @UlisesGascon. Please 👍 to approve.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.50%. Comparing base (6698675) to head (e51f833).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #66877   +/-   ##
=======================================
  Coverage   90.50%   90.50%           
=======================================
  Files         797      797           
  Lines      278256   278256           
  Branches    53472    53464    -8     
=======================================
+ Hits       251822   251848   +26     
+ Misses      16803    16768   -35     
- Partials     9631     9640    +9     

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
aduh95 merged commit ae22341 into nodejs:main Oct 20, 2026
81 of 85 checks passed
@aduh95

aduh95 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor Author

Landed in ae22341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. tls Issues and PRs related to the tls subsystem. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants