Repository navigation
build,win: fix Perfetto - #66876
Open
aduh95 wants to merge 2 commits into
Open
build,win: fix Perfetto#66876aduh95 wants to merge 2 commits into
aduh95 wants to merge 2 commits into
Conversation
Original commit message:
[tracing] do not define legacy tracing classes when using Perfetto
Otherwise the Windows build of Node.js fails with `undefined symbol`
errors due to the missing destructor.
Change-Id: Id0841aed2f0a8f0cfe8889c39150552e31ee5f96
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/8580049
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Chengzhong Wu <cwu631@bloomberg.net>
Commit-Queue: Chengzhong Wu <cwu631@bloomberg.net>
Cr-Commit-Position: refs/heads/main@{#110947}
Refs: v8/v8@785a2ea
Signed-off-by: StefanStojanovic <stefan.stojanovic@janeasystems.com>
Collaborator
|
Review requested:
|
aduh95
added
dont-land-on-v22.x
nodejs-github-bot
added
build
legendecas
approved these changes
Oct 20, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
lpinca
approved these changes
Oct 20, 2026
Collaborator
juanarbol
approved these changes
Oct 20, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for #65794