Repository navigation
test_runner: keep never-run blocks when merging coverage - #66873
Open
junaidkhan80121 wants to merge 1 commit into
Open
junaidkhan80121 wants to merge 1 commit into
junaidkhan80121 wants to merge 1 commit into
Conversation
V8 omits a nested block when its count equals its parent. The old set-based merge dropped those uncovered ranges across processes, so coverage gates could pass. Merge with a range tree instead, matching V8/c8 semantics. Fixes: nodejs#66860 Signed-off-by: Junaid Khan <khanjunaid80121@gmail.com>
Collaborator
|
Review requested:
|
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #66860
V8 omits a nested block when its count equals its parent. The previous
set-based merge dropped those never-run ranges when combining process
coverages, so a second less-covered process could make a failing branch
gate pass.
This switches function-range merging to a range-tree merge (same
approach as c8 /
@bcoe/v8-coverage). Multi-process coverage for thecombined fixture now matches
--test-isolation=none.Test plan
./out/Release/node test/parallel/test-runner-coverage-merge-nested.js./out/Release/node test/parallel/test-runner-coverage.js./out/Release/node test/parallel/test-runner-coverage-thresholds.jsAI assistance was used while drafting this change. I reviewed the
merge logic against the issue and
@bcoe/v8-coverage, reproduced thebug, verified the fix with a locally built Node, and ran the tests
above.